go version should be at least 1.16 because of io.Discard(Since Go 1.16, Feb 2021)…

[wxiaoguang]

Currently the go version is 1.14 in go.mod, actually there are many usage of io.Discard(Since Go 1.16, Feb 2021) in code

So go version should be at least 1.16 now. And README.md is also updated.

[codecov-commenter]

Codecov Report

Merging #16764 (9d6f888) into main (7844bf1) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #16764      +/-   ##
==========================================
+ Coverage   45.34%   45.36%   +0.01%     
==========================================
  Files         760      760              
  Lines       85504    85504              
==========================================
+ Hits        38774    38785      +11     
+ Misses      40439    40432       -7     
+ Partials     6291     6287       -4     

Impacted Files	Coverage Δ
modules/util/timer.go	42.85% <0.00%> (-42.86%)	⬇️
modules/queue/workerpool.go	53.05% <0.00%> (-1.91%)	⬇️
models/issue_comment.go	51.76% <0.00%> (+0.29%)	⬆️
services/pull/pull.go	41.78% <0.00%> (+0.40%)	⬆️
models/repo_list.go	78.43% <0.00%> (+0.78%)	⬆️
models/notification.go	66.00% <0.00%> (+0.87%)	⬆️
modules/notification/ui/ui.go	62.31% <0.00%> (+1.44%)	⬆️
modules/log/event.go	62.50% <0.00%> (+1.85%)	⬆️
modules/notification/mail/mail.go	38.23% <0.00%> (+2.94%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7844bf1...9d6f888. Read the comment docs.

[6543]

@wxiaoguang Discard do work with 1.14 any points in bumping requirement?

[techknowlogick]

@6543 we've already defined 1.16 as minimum, so it is good to have it in the places defined in this PR

[6543]

oh yes that one dep.

[kpfleming]

The release notes for Gitea 1.15.0 say that Go 1.15 or later is required, but this PR made the requirement 1.16 or later.

[zeripath]

• It's not this PR that's responsible but release/v1.15: set min go version to min upstream supported go1.16 #16710

DAMN we should have updated the blog at that point.

Realistically we can't support 1.15 as upstream projects like golang-jwt/jwt will not support out-of-support golang versions - and will not even attempt to provide security fixes for them.

I agree its not great but as 1.15 was released after the end of life for go 1.15 I don't think we can say we can support 1.15.

(If you really need to use go 1.15 the source for Gitea code will compile with go 1.15 if you change the Makefile.)

[zeripath]

I've put up a PR to update/fix the blog https://gitea.com/gitea/blog/pulls/171

[kpfleming]

I'm good, I upgraded to Go 1.17 and Gitea 1.15 is working great (and quite a bit faster than 1.14 was when built with Go 1.15).

[zeripath]

quite a bit faster than 1.14

This is no accident, I (and lunny) have sent substantial numbers of PRs to improve speed. The one most likely responsible for your experience improvement is #16059.