Prevent coverage break #16887
Merged
Prevent coverage break #16887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are repeated failures of our CI due to an intermittent issue with coverage.out finishing with a spurious `0` on a single line. This problem is very annoying and very hard to understand where it is coming from, therefore as the problem appears random and without clear cause we should just strip this line from our coverage. Signed-off-by: Andrew Thornton <art27@cantab.net>
GiteaBot
added
the
lgtm/need 1
6543
added
the
skip-changelog
techknowlogick
approved these changes
Aug 30, 2021
GiteaBot
added
lgtm/done
|
🚀 |
Codecov Report
@@ Coverage Diff @@
## main #16887 +/- ##
=======================================
Coverage 45.46% 45.46%
=======================================
Files 762 762
Lines 86104 86116 +12
=======================================
+ Hits 39150 39156 +6
- Misses 40642 40650 +8
+ Partials 6312 6310 -2
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are repeated failures of our CI due to an intermittent issue with coverage.out
finishing with a spurious
0on a single line.This problem is very annoying and very hard to understand where it is coming from,
therefore as the problem appears random and without clear cause we should just strip
this line from our coverage.
These bugs are occurring due to the change to use the race detector - presumably there is some race occurring in the coverage output.
Related #1441
Signed-off-by: Andrew Thornton art27@cantab.net