Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitlab Migrator: dont ignore reactions of last request #16903

Merged
merged 4 commits into from
Sep 1, 2021
Merged

Gitlab Migrator: dont ignore reactions of last request #16903

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
17a1537
Gitlab Migrator: dont ignore reactions of last request
6543 Aug 31, 2021
71ab382
Merge branch 'main' into move-break-to-right-place
6543 Aug 31, 2021
584fa17
CI.restart()
6543 Aug 31, 2021
e0ded37
Merge branch 'main' into move-break-to-right-place
zeripath Sep 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions modules/migrations/gitlab.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,12 +421,15 @@ func (g *GitlabDownloader) GetIssues(page, perPage int) ([]*base.Issue, bool, er
if err != nil {
return nil, false, fmt.Errorf("error while listing issue awards: %v", err)
}
if len(awards) < perPage {
break
}

for i := range awards {
reactions = append(reactions, g.awardToReaction(awards[i]))
}

if len(awards) < perPage {
break
}

awardPage++
}

Expand Down Expand Up @@ -584,12 +587,15 @@ func (g *GitlabDownloader) GetPullRequests(page, perPage int) ([]*base.PullReque
if err != nil {
return nil, false, fmt.Errorf("error while listing merge requests awards: %v", err)
}
if len(awards) < perPage {
break
}

for i := range awards {
reactions = append(reactions, g.awardToReaction(awards[i]))
}

if len(awards) < perPage {
break
}

awardPage++
}

Expand Down