Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the final test from the testlogger safely #16907

Merged

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Aug 31, 2021

It is possible to get a data race right at the end of the TestMain
in integrations during the final removal of the test from the testlogger. This PR
uses a Reset function to remove any final tests but adds some extra
logging which will forcibly fail if there is an unclosed logger.

Related #1441

Signed-off-by: Andrew Thornton art27@cantab.net

It is possible to get final data race right at the end of the TestMain
in integrations during the final removal of the test from it. This PR
uses a Reset function to remove any final tests but adds some extra
logging which will forcibly fail if there is an unclosed logger.

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added type/testing skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Aug 31, 2021
@zeripath zeripath added this to the 1.16.0 milestone Aug 31, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 31, 2021
@zeripath zeripath changed the title Ensure that the testlogger has its final test removal safely Remove the final test from the testlogger safely Sep 1, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 1, 2021
@zeripath
Copy link
Contributor Author

zeripath commented Sep 1, 2021

make lgtm work

@zeripath zeripath merged commit 6e0e414 into go-gitea:main Sep 1, 2021
@zeripath zeripath deleted the prevent-data-race-during-test-shutdown branch September 1, 2021 13:05
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants