-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move db related basic functions to models/db #17075
Conversation
c870928
to
43f4e97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise lgtm
Codecov Report
@@ Coverage Diff @@
## main #17075 +/- ##
==========================================
+ Coverage 45.24% 45.25% +0.01%
==========================================
Files 771 773 +2
Lines 86767 86828 +61
==========================================
+ Hits 39255 39292 +37
- Misses 41160 41181 +21
- Partials 6352 6355 +3
Continue to review full report at Codecov.
|
Since
models
becomes more and more big, splitting it becomes a task to refactor.This PR create a new subpackage
models/db
and move common database functions to that package.The next PRs should create business logic related subpackages of
models
and move related codes there. i.e. Moving allmodels/issue*.go
tomodels/issues/
.