Fix missing repo link in issue/pull assigned emails #17183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a mistake in the template file: `templates/mail/issue/assigned.tmpl` where the repourl was generated from a non-existent release instead of the issue. This PR changes this to use the issue but also ensure that the issue repo is loaded. It also slightly improves the English locale string. Fix go-gitea#17160 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
force-pushed
the
fix-17160-use-issue-for-repo-in-mail-templates
branch
from
1898c3c
to
9e3438d
Compare
noerw
approved these changes
Sep 29, 2021
GiteaBot
added
the
lgtm/need 1
axifive
approved these changes
Sep 29, 2021
GiteaBot
added
lgtm/done
silverwind
approved these changes
Sep 29, 2021
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Sep 29, 2021
Backport go-gitea#17183 There was a mistake in the template file: `templates/mail/issue/assigned.tmpl` where the repourl was generated from a non-existent release instead of the issue. This PR changes this to use the issue but also ensure that the issue repo is loaded. It also slightly improves the English locale string. Fix go-gitea#17160 Signed-off-by: Andrew Thornton <art27@cantab.net>
6543
approved these changes
Sep 29, 2021
delvh
approved these changes
Sep 29, 2021
Co-authored-by: delvh <dev.lh@web.de>
Codecov Report
@@ Coverage Diff @@
## main #17183 +/- ##
==========================================
- Coverage 45.31% 45.30% -0.02%
==========================================
Files 779 779
Lines 87226 87229 +3
==========================================
- Hits 39530 39520 -10
- Misses 41285 41290 +5
- Partials 6411 6419 +8
Continue to review full report at Codecov.
|
6543
added a commit
that referenced
this pull request
Sep 29, 2021
Backport #17183 There was a mistake in the template file: `templates/mail/issue/assigned.tmpl` where the repourl was generated from a non-existent release instead of the issue. This PR changes this to use the issue but also ensure that the issue repo is loaded. It also slightly improves the English and the Russian locale string. Fix #17160 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: 6543 <6543@obermui.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a mistake in the template file:
templates/mail/issue/assigned.tmplwhere the repourl was generated from a non-existent release instead of the issue.
This PR changes this to use the issue but also ensure that the issue repo is loaded.
It also slightly improves the English locale string.
Fix #17160
Signed-off-by: Andrew Thornton art27@cantab.net