Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve behavior of "Fork" button #17288
Improve behavior of "Fork" button #17288
Changes from 2 commits
3b641de
24b83ee
4a1facf
97fb7bd
c822b22
5bb9f9f
859f69c
265d9cf
128c2e6
9dd9098
0a25a69
eb261c5
125c1c8
01a6e67
ad23347
1a89f5d
6f86036
654738f
4fc7b08
5d9c5f9
af026cb
ae7e9fa
9667754
4097805
6a4ab3a
be1bfba
d094c23
3917a02
d02ee5c
3968d00
85149a9
f9f224d
34641cf
75ce8ac
862d39a
73cc7e8
813ead4
f87c0dc
6621589
214651a
43c0cfd
7a6ec83
5b41a0a
bbb458f
45d7872
71dfc97
c85aff6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just very curious to ask ... why do we need this css style? I use
!important
for only one or two times in all my projects, but I see!important
in Gitea css code everywhere.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just added another one, because every dialog/modal is listed in this css style... (but I don't know why there is this style)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will the modal dialog work without this style? If it works alright, we can get rid of this strange styling ....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it doesn't work without this style
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
important is needed because of semanatic/fomantic css that is not very though out and uses important all over the place so we also have to use important to style it :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anytime you need to override vendor CSS, it's a good idea to use
!important
. We should of course reduce unnecessary use, of which there are also a few cases.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, there is a
w-100
helper CSS class forwidth: 100% !important;
, please use that instead.gitea/web_src/less/helpers.less
Line 15 in bdfd751
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@silverwind If I remove the
fork-repo-modal
and add thew-100
class to the modal, it doesn't work (the content of thefork-repo-modal
class is.ui.message { width: 100% !important; }
and notwidth: 100% !important;
)