docs: add permission notes to SSH Container Passthrough
#17347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxiaoguang
reviewed
Oct 18, 2021
| ```bash | ||
| sudo chmod +x /app/gitea/gitea | ||
| ``` | ||
|
|
There was a problem hiding this comment.
I can not understand why we need this step. If the gitea binary doesn't have +x, how can it be started before?
Oh I can see your point ~~ . Then the text should be you should set instead of you may 😊
GiteaBot
added
the
lgtm/need 2
This comment has been minimized.
This comment has been minimized.
wxiaoguang
reviewed
Oct 18, 2021
| @@ -336,6 +336,12 @@ In the next step a file named `/app/gitea/gitea` (with executable permissions) n | |||
| ssh -p 2222 -o StrictHostKeyChecking=no git@127.0.0.1 "SSH_ORIGINAL_COMMAND=\"$SSH_ORIGINAL_COMMAND\" $0 $@" | |||
There was a problem hiding this comment.
Can you help to add a shebang line #!/bin/sh here? In case some users are using non-sh shells.
|
Please improve the description of this PR |
|
Ready |
wxiaoguang
approved these changes
Oct 18, 2021
GiteaBot
added
lgtm/need 1
delvh
approved these changes
Oct 18, 2021
GiteaBot
added
lgtm/done
wxiaoguang
added
type/docs
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
…7347) * Update with-docker.en-us.md * Update with-docker.en-us.md Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This step is necessary in most cases and should be noted in the docs.