Implementation of all repositories of a user from user->settings #1740

DblK · 2017-05-17T14:47:19Z

This PR implement the display of all repository owned by the user in its settings.

Here is the UI:

The menu:

With no repository:

With all kind of repositories:

sondr3 · 2017-05-17T15:16:50Z

options/locale/locale_en-US.ini

@@ -429,6 +430,8 @@ remove_account_link = Remove linked account
 remove_account_link_desc = Delete this account link will remove all related access for your account. Do you want to continue?
 remove_account_link_success = Account link has been removed successfully!

+repos_none = You do not owned any repository


The phrasing on this is a bit awkward, "You do not own any repositories" is more correct. Although I'm not sure using "own" here is the right term either.

"You do not have any repositories", maybe?

Ah, yeah, that sounds a lot better in my opinion. Maybe even "You do not currently have any repositories". 😃

pgaskin · 2017-05-17T20:11:00Z

options/locale/locale_en-US.ini

@@ -430,7 +430,7 @@ remove_account_link = Remove linked account
 remove_account_link_desc = Delete this account link will remove all related access for your account. Do you want to continue?
 remove_account_link_success = Account link has been removed successfully!

-repos_none = You do not owned any repository
+repos_none = You do not currently have any repositories


That's a bit wordy and is not consistent with the rest of the strings. I think it should be "You do not own any repositories".

I commented on this earlier and I don't like the wording where you own repositories, I get the meaning behind it but don't think it's too accurate.

All the other strings refer to it as owning repositories. Consistency makes everything easier to use and look like everything fits together. What do you mean by it isn't too accurate.

bkcsoft

Otherwise LGTM :)

bkcsoft · 2017-05-20T21:48:31Z

options/locale/locale_fr-FR.ini

@@ -272,6 +272,7 @@ ssh_keys=Clés SSH
 social=Réseaux Sociaux
 applications=Applications
 orgs=Organisations
+repos=Dépôts


This should be done via CrowdIn. (all languages other than English)

I removed the french translation

bkcsoft · 2017-05-21T21:05:50Z

Looks good 🙂 why the ad-hoc list though? It differs from all other lists (tables) in the App. Looks very "thrown together" and out of place 😕

DblK · 2017-05-22T13:38:59Z

You are right. I didn't know how to display it. It was the same as Github was before.
Here is the new UI I've done for this:

L-G-T-M does not seems to see your last comments.
Commit and push will be done pretty soon ;)

strk · 2017-05-28T04:45:02Z

LGTM - but it would be great if you could add integration tests for this new endpoint.

pgaskin · 2017-06-16T02:30:46Z

LGTM

lunny · 2017-06-16T02:47:20Z

@geek1011 so many conflicted files?

pgaskin · 2017-06-16T04:15:29Z

@lunny I was saying L-G-T-M about the idea, and the fact that it works when that branch is built, not the conflicts when merging it.

bkcsoft · 2017-06-19T06:36:46Z

fixed merge-conflicts

lunny · 2017-06-23T01:36:32Z

It seems there is a line break after the icon?

lunny · 2017-06-23T06:35:33Z

@DblK Please confirm the problem, maybe we could move this to v1.2.

pgaskin · 2017-06-23T22:03:31Z

@lunny @DblK Yes, there is a problem.

It can be fixed by making the icon and content inline-block, instead of floating it. Floating is less predictable, and it does not work because the content div fills as much space as possible.

DblK · 2017-07-04T12:29:17Z

I'll fix it soon I hope kinda busy right now.

lunny · 2017-08-28T01:32:34Z

This could be merged after the little problem resolved. @DblK maybe some maintainer could help you if you are busy now.

DblK · 2017-09-09T01:35:21Z

If someone else cqn finish it go for it. Not much time right now.

lunny · 2017-09-14T09:34:10Z

rebased and see below screenshot.

codecov-io · 2017-09-14T09:48:44Z

Codecov Report

❗ No coverage uploaded for pull request base (master@1739e84). Click here to learn what that means.
The diff coverage is 0%.

@@           Coverage Diff            @@
##             master   #1740   +/-   ##
========================================
  Coverage          ?   27.7%           
========================================
  Files             ?      83           
  Lines             ?   16914           
  Branches          ?       0           
========================================
  Hits              ?    4686           
  Misses            ?   11553           
  Partials          ?     675

Impacted Files	Coverage Δ
routers/user/setting.go	`0% <0%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1739e84...c3146b3. Read the comment docs.

lunny added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label May 17, 2017

lunny added this to the 1.3.0 milestone May 17, 2017

sondr3 reviewed May 17, 2017

View reviewed changes

pgaskin reviewed May 17, 2017

View reviewed changes

bkcsoft suggested changes May 20, 2017

View reviewed changes

bkcsoft approved these changes May 21, 2017

View reviewed changes

tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 21, 2017

tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 28, 2017

tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 16, 2017

DblK and others added 6 commits September 14, 2017 17:17

Implementation of all repositories of a user from user->settings

62146e8

Update message when no repository found

88c18a0

Update according to comments

cb46e6c

Remove french translation

81fd544

Change UI to have a better look

371cb99

improved user repositories UI

c3146b3

lunny force-pushed the feature_UserRepo branch from 38c4031 to c3146b3 Compare September 14, 2017 09:32

lafriks merged commit e5d80b7 into go-gitea:master Sep 14, 2017

go-gitea locked and limited conversation to collaborators Nov 23, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implementation of all repositories of a user from user->settings #1740

Implementation of all repositories of a user from user->settings #1740

DblK commented May 17, 2017

sondr3 May 17, 2017

DblK May 17, 2017

sondr3 May 17, 2017

pgaskin May 17, 2017 •

edited

Loading

sondr3 May 17, 2017

pgaskin May 17, 2017

bkcsoft left a comment

bkcsoft May 20, 2017

DblK May 21, 2017

bkcsoft commented May 21, 2017

DblK commented May 22, 2017

strk commented May 28, 2017

pgaskin commented Jun 16, 2017

lunny commented Jun 16, 2017

pgaskin commented Jun 16, 2017 •

edited

Loading

bkcsoft commented Jun 19, 2017

lunny commented Jun 23, 2017

lunny commented Jun 23, 2017

pgaskin commented Jun 23, 2017

DblK commented Jul 4, 2017

lunny commented Aug 28, 2017

DblK commented Sep 9, 2017

lunny commented Sep 14, 2017

codecov-io commented Sep 14, 2017

Implementation of all repositories of a user from user->settings #1740

Implementation of all repositories of a user from user->settings #1740

Conversation

DblK commented May 17, 2017

sondr3 May 17, 2017

Choose a reason for hiding this comment

DblK May 17, 2017

Choose a reason for hiding this comment

sondr3 May 17, 2017

Choose a reason for hiding this comment

pgaskin May 17, 2017 • edited Loading

Choose a reason for hiding this comment

sondr3 May 17, 2017

Choose a reason for hiding this comment

pgaskin May 17, 2017

Choose a reason for hiding this comment

bkcsoft left a comment

Choose a reason for hiding this comment

bkcsoft May 20, 2017

Choose a reason for hiding this comment

DblK May 21, 2017

Choose a reason for hiding this comment

bkcsoft commented May 21, 2017

DblK commented May 22, 2017

strk commented May 28, 2017

pgaskin commented Jun 16, 2017

lunny commented Jun 16, 2017

pgaskin commented Jun 16, 2017 • edited Loading

bkcsoft commented Jun 19, 2017

lunny commented Jun 23, 2017

lunny commented Jun 23, 2017

pgaskin commented Jun 23, 2017

DblK commented Jul 4, 2017

lunny commented Aug 28, 2017

DblK commented Sep 9, 2017

lunny commented Sep 14, 2017

codecov-io commented Sep 14, 2017

Codecov Report

pgaskin May 17, 2017 •

edited

Loading

pgaskin commented Jun 16, 2017 •

edited

Loading