Show correct "No" icon #17537
Merged
Show correct "No" icon #17537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delvh
added
backport/v1.15
type/bug
topic/ui
delvh
added
the
topic/ui-interaction
silverwind
approved these changes
Nov 3, 2021
GiteaBot
added
the
lgtm/need 1
lunny
approved these changes
Nov 4, 2021
GiteaBot
added
lgtm/done
4 tasks
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the previously present "Trash" icon on "No" with the intended cross:
(ignore the filename at the bottom, that was an oversight while taking the screenshot)
This way, there won't be confusion in case you delete something and the "No" icon displays the trash can.
It is possible that something else will look slightly worse afterwards, but that is a tradeoff I'm willing to make as it does not lead to as much confusion as it does now.
Fixes #17535.
Backports: #17537, #17538