-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix close issue but time watcher still running #17643
Conversation
88a6efc
to
aad2199
Compare
aad2199
to
d506655
Compare
Codecov Report
@@ Coverage Diff @@
## main #17643 +/- ##
==========================================
+ Coverage 45.44% 45.51% +0.06%
==========================================
Files 802 807 +5
Lines 89233 89842 +609
==========================================
+ Hits 40556 40892 +336
- Misses 42140 42408 +268
- Partials 6537 6542 +5
Continue to review full report at Codecov.
|
I think this is incorrect and rather the error handling should be happening at the caller end. |
Unfortunately go-gitea#17643 prevented all propagation of ErrDependenciesLeft meaning that dependency errors that prevent closing of issues get swallowed. This PR restores propagation of the error but instead swallows the error in the places where it needs to be swallowed. Fix go-gitea#18223 Signed-off-by: Andrew Thornton <art27@cantab.net>
Unfortunately #17643 prevented all propagation of ErrDependenciesLeft meaning that dependency errors that prevent closing of issues get swallowed. This PR restores propagation of the error but instead swallows the error in the places where it needs to be swallowed. Fix #18223 Signed-off-by: Andrew Thornton <art27@cantab.net>
* Fix close issue but time watcher still running * refactor stopwatch codes * Fix test * Fix test * Fix typo * Fix test
Unfortunately go-gitea#17643 prevented all propagation of ErrDependenciesLeft meaning that dependency errors that prevent closing of issues get swallowed. This PR restores propagation of the error but instead swallows the error in the places where it needs to be swallowed. Fix go-gitea#18223 Signed-off-by: Andrew Thornton <art27@cantab.net>
Fix #11374