Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename RepoCreationNum -> MaxCreationLimit #1766

Merged
merged 1 commit into from
May 24, 2017

Conversation

cez81
Copy link
Contributor

@cez81 cez81 commented May 19, 2017

Old name sounds more like it will return number of created repositories when in fact it returns the number of repositories the user is allowed to create.

@ethantkoenig
Copy link
Member

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 24, 2017
@lunny lunny added this to the 1.2.0 milestone May 24, 2017
@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label May 24, 2017
@lunny
Copy link
Member

lunny commented May 24, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 24, 2017
@lunny lunny merged commit 7b907ed into go-gitea:master May 24, 2017
@ethantkoenig ethantkoenig mentioned this pull request May 24, 2017
@cez81 cez81 deleted the RepoCreationNum_rename branch May 24, 2017 05:56
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants