Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify code for writing SHA to name-rev #17696

Merged
merged 3 commits into from
Nov 18, 2021
Merged

Simplify code for writing SHA to name-rev #17696

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
04a3a00
Simplify code for wrting SHA to name-rev
Nov 17, 2021
06bf9da
Merge branch 'main' into simplify-sha-writing
lunny Nov 18, 2021
16c7aa5
Merge branch 'main' into simplify-sha-writing
6543 Nov 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 8 additions & 17 deletions modules/git/pipeline/lfs_nogogit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,24 +217,15 @@ func FindLFSFile(repo *git.Repository, hash git.SHA1) ([]*LFSResult, error) {
defer wg.Done()
defer shasToNameWriter.Close()
for _, result := range results {
i := 0
if i < len(result.SHA) {
n, err := shasToNameWriter.Write([]byte(result.SHA)[i:])
if err != nil {
errChan <- err
break
}
i += n
_, err := shasToNameWriter.Write([]byte(result.SHA))
if err != nil {
errChan <- err
break
}
var err error
n := 0
for n < 1 {
n, err = shasToNameWriter.Write([]byte{'\n'})
if err != nil {
errChan <- err
break
}

_, err = shasToNameWriter.Write([]byte{'\n'})
if err != nil {
errChan <- err
break
}

}
Expand Down