Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary X-Remote HTTP header in AJAX request #17932

Merged
merged 1 commit into from
Dec 8, 2021
Merged

Remove unnecessary X-Remote HTTP header in AJAX request #17932

merged 1 commit into from
Dec 8, 2021

Conversation

wxiaoguang
Copy link
Contributor

There are many X-Remote: true header in jQuery AJAX request.

These headers is likely added by misunderstanding and copy&paste.

This PR removes these unnecessary headers, and prevent developers from copying&pasting these incorrect headers to new code in future.

@wxiaoguang wxiaoguang added type/refactoring Existing code has been cleaned up. There should be no new functionality. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Dec 8, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 8, 2021
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@a6f961f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #17932   +/-   ##
=======================================
  Coverage        ?   45.34%           
=======================================
  Files           ?      815           
  Lines           ?    90723           
  Branches        ?        0           
=======================================
  Hits            ?    41142           
  Misses          ?    43015           
  Partials        ?     6566

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6f961f...dd4acc7. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 8, 2021
@techknowlogick techknowlogick added this to the 1.16.0 milestone Dec 8, 2021
@wxiaoguang wxiaoguang merged commit 4cbe792 into go-gitea:main Dec 8, 2021
@wxiaoguang wxiaoguang deleted the remove-x-remote branch December 8, 2021 06:21
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@wxiaoguang
Remove unnecessary X-Remote HTTP header in AJAX request (go-gitea#1…
16a4211 
…7932)
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.
5 participants
@wxiaoguang @codecov-commenter @lunny @techknowlogick @GiteaBot