Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move POST /{username}/action/{action} to simply POST /{username} (#18045) #18046

Merged
merged 2 commits into from
Dec 20, 2021

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Dec 20, 2021

Backport #18045

The current code unfortunately requires that action be a reserved
repository name as it prevents posts to change the settings for
action repositories. However, we can simply change action handler
to work on POST /{username} instead.

Fix #18037

Signed-off-by: Andrew Thornton art27@cantab.net

@zeripath zeripath added this to the 1.15.8 milestone Dec 20, 2021
@zeripath zeripath changed the title Move POST /{username}/action/{action} to simply POST /{username} (#18… Move POST /{username}/action/{action} to simply POST /{username} (#18045) Dec 20, 2021
@zeripath zeripath changed the title Move POST /{username}/action/{action} to simply POST /{username} (#18045) Move POST /{username}/action/{action} to simply POST /{username} (#18037) Dec 20, 2021
@zeripath zeripath changed the title Move POST /{username}/action/{action} to simply POST /{username} (#18037) Move POST /{username}/action/{action} to simply POST /{username} (#18045) Dec 20, 2021
…gitea#18045)

Backport go-gitea#18045

The current code unfortunately requires that `action` be a reserved
repository name as it prevents posts to change the settings for
action repositories. However, we can simply change action handler
to work on POST /{username} instead.

Fix go-gitea#18037

Signed-off-by: Andrew Thornton <art27@cantab.net>
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 20, 2021
zeripath added a commit to zeripath/gitea that referenced this pull request Dec 20, 2021
Add:

* Move POST /{username}/action/{action} to simply POST /{username} (go-gitea#18045) (go-gitea#18046)
* Fix delete u2f keys bug (go-gitea#18040) (go-gitea#18042)
* Reset Session ID on login (go-gitea#18018) (go-gitea#18041)
* Prevent off-by-one error on comments on newly appended lines (go-gitea#18029) (go-gitea#18035)

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this pull request Dec 20, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 20, 2021
@techknowlogick techknowlogick merged commit a818a48 into go-gitea:release/v1.15 Dec 20, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
@zeripath zeripath deleted the backport-18045-v1.15 branch December 29, 2022 19:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants