Fix: unstable sort skips/duplicates issues across pages #18094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxiaoguang
reviewed
Dec 24, 2021
GiteaBot
added
the
lgtm/need 2
Codecov Report
@@ Coverage Diff @@
## main #18094 +/- ##
=======================================
Coverage 44.89% 44.89%
=======================================
Files 824 824
Lines 91581 91589 +8
=======================================
+ Hits 41111 41116 +5
+ Misses 43879 43876 -3
- Partials 6591 6597 +6
Continue to review full report at Codecov.
|
KN4CK3R
reviewed
Dec 24, 2021
KN4CK3R
reviewed
Dec 24, 2021
KN4CK3R
reviewed
Dec 24, 2021
KN4CK3R
reviewed
Dec 24, 2021
models/issue.go
Outdated
| case "project-column-sorting": | ||
| sess.Asc("project_issue.sorting") | ||
| sess.Asc("project_issue.sorting").Desc("issue.id") |
There was a problem hiding this comment.
Suggested change
| sess.Asc("project_issue.sorting").Desc("issue.id") | |
| sess.Asc("project_issue.sorting").Asc("issue.id") |
There was a problem hiding this comment.
I'm not sure how project issue sorting works. What's the reasoning here?
When viewing issues in sorted order, some issues are duplicated across pages and some are missing. This is caused by the lack of tie-breakers in database queries, making pagination inconsistent.
wxiaoguang
approved these changes
Dec 25, 2021
GiteaBot
added
lgtm/need 1
|
@lafriks can you also review this PR? |
lafriks
approved these changes
Dec 29, 2021
GiteaBot
added
lgtm/done
|
Looks good from my side |
wxiaoguang
approved these changes
Dec 29, 2021
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Dec 29, 2021
* giteaoffical/main: Fix: unstable sort skips/duplicates issues across pages (go-gitea#18094)
6543
added
backport/done
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
When viewing issues in sorted order, some issues are duplicated across pages and some are missing. This is caused by the lack of tie-breakers in database queries, making pagination inconsistent.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When viewing issues in sorted order, some issues are duplicated across pages and some are missing. This is caused by the lack of tie-breakers in database queries, making pagination inconsistent.
Fixes #13395.