Fix deadlock in updateRepository #1813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tboerger
added
the
lgtm/need 2
|
LGTM |
tboerger
added
lgtm/need 1
lunny
reviewed
May 26, 2017
| repoInfoSize, err := git.GetRepoSize(repo.RepoPath()) | ||
| if err != nil { | ||
| return fmt.Errorf("UpdateSize: %v", err) | ||
| } | ||
|
|
||
| repo.Size = repoInfoSize.Size + repoInfoSize.SizePack | ||
| _, err = x.ID(repo.ID).Cols("size").Update(repo) | ||
| _, err = e.Id(repo.ID).Cols("size").Update(repo) |
There was a problem hiding this comment.
ID is not in the Engine interface.
|
A small change required, otherwise LGTM |
tboerger
added
lgtm/done
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a potential deadlock in
updateRepository(). The call toUpdateSize()previously did not use the provided session (i.e. theeparameter), and the resulting query could become blocked by the ongoing session/transaction, since both the query and the ongoing transaction need to access therepositorytable.I experienced this deadlock locally, using PostgreSQL.