Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slight optimization for default avatar #18187

Merged
merged 3 commits into from
Jan 5, 2022
Merged

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 5, 2022

No description provided.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 5, 2022
@6543 6543 added this to the 1.16.0 milestone Jan 5, 2022
models/avatars/avatar.go Outdated Show resolved Hide resolved
Co-authored-by: 6543 <6543@obermui.de>
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 5, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@ec6cc38). Click here to learn what that means.
The diff coverage is 62.50%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #18187   +/-   ##
=======================================
  Coverage        ?   45.68%           
=======================================
  Files           ?      828           
  Lines           ?    91776           
  Branches        ?        0           
=======================================
  Hits            ?    41925           
  Misses          ?    43120           
  Partials        ?     6731           
Impacted Files Coverage Δ
models/avatars/avatar.go 33.33% <62.50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec6cc38...d6b251f. Read the comment docs.

@6543 6543 merged commit 6da078d into go-gitea:main Jan 5, 2022
@lunny lunny deleted the lunny/default_avatar branch January 5, 2022 06:13
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 6, 2022
* 'main' of https://github.com/go-gitea/gitea:
  Enable partial clone by default (go-gitea#18195)
  Add option to convert CRLF to LF line endings for sendmail (go-gitea#18075)
  Add replay of webhooks. (go-gitea#18191)
  Load EasyMDE/CodeMirror dynamically, remove RequireEasyMDE (go-gitea#18069)
  refactoring nits (go-gitea#18188)
  slight optimization for default avatar (go-gitea#18187)
  code.gitea.io/sdk/gitea v0.14.0 -> v0.15.1 (go-gitea#18186)
  Team permission allow different unit has different permission (go-gitea#17811)
  Integration test for migration (go-gitea#18124)
  Update `TODOs` badge to reflect new default branch (go-gitea#18182)
  Increase Salt randomness  (go-gitea#18179)
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
* slight optimization

* Update comment

Co-authored-by: 6543 <6543@obermui.de>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/miscellaneous
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants