Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix release link broken (#18252) #18253

Merged
merged 3 commits into from
Jan 14, 2022
Merged

Fix release link broken (#18252) #18253

merged 3 commits into from
Jan 14, 2022

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 12, 2022 •
edited by zeripath
Loading

backport from #18252

Fix #18226

@lunny lunny added the type/bug label Jan 12, 2022
@lunny lunny added this to the 1.15.10 milestone Jan 12, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 12, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 12, 2022
@lunny lunny force-pushed the lunny/fix_release_broken2 branch from 77061a8 to 826afa1 Compare January 13, 2022 16:43
@lunny
Copy link
Member Author

lunny commented Jan 13, 2022

@OCram85 Could you help to confirm this PR fix your problem? I cannot reproduce it on my local Gitea instance.

@OCram85
Copy link
Contributor

OCram85 commented Jan 13, 2022 •
edited
Loading

I could spin up a gitea container in my test environment. Is there an image/tag which already contains the PR? I'm not 100% familiar with the drone.io pipelines used in this repo :D

@lunny
Copy link
Member Author

lunny commented Jan 13, 2022

@OCram85 OKay. I can confirm that this is fixed and I found it should be affected by a migrated repository from another Gitea instance or from Github.

@6543 6543 merged commit 14de28b into go-gitea:release/v1.15 Jan 14, 2022
@lunny lunny deleted the lunny/fix_release_broken2 branch January 14, 2022 02:40
@zeripath zeripath changed the title Fix release link broken Fix release link broken (#18252) Jan 14, 2022
@richmahn richmahn mentioned this pull request Jan 14, 2022
Merged
zeripath pushed a commit that referenced this pull request Jan 14, 2022
@richmahn
Changelog for 1.15.10 (#18274)
a6f9ebf 
[1.15.10](https://github.com/go-gitea/gitea/releases/tag/v1.15.10) - 2022-01-14

* BUGFIXES
  * Fix inconsistent PR comment counts (#18260) (#18261)
  * Fix release link broken (#18252) (#18253)
  * Fix update user from site administration page bug (#18250) (#18251)
  * Set HeadCommit when creating tags (#18116) (#18173)
  * Use correct translation key for error messages due to max repo limits (#18135 & #18153) (#18152)
  * Fix purple color in suggested label colors (#18241) (#18242)
* SECURITY
  * Bump mermaid from 8.10.1 to 8.13.8 (#18198) (#18206)
zeripath pushed a commit to zeripath/gitea that referenced this pull request Jan 14, 2022
@richmahn @zeripath
Changelog for 1.15.10 (go-gitea#18274)
caea4f2 
[1.15.10](https://github.com/go-gitea/gitea/releases/tag/v1.15.10) - 2022-01-14

* BUGFIXES
  * Fix inconsistent PR comment counts (go-gitea#18260) (go-gitea#18261)
  * Fix release link broken (go-gitea#18252) (go-gitea#18253)
  * Fix update user from site administration page bug (go-gitea#18250) (go-gitea#18251)
  * Set HeadCommit when creating tags (go-gitea#18116) (go-gitea#18173)
  * Use correct translation key for error messages due to max repo limits (go-gitea#18135 & go-gitea#18153) (go-gitea#18152)
  * Fix purple color in suggested label colors (go-gitea#18241) (go-gitea#18242)
* SECURITY
  * Bump mermaid from 8.10.1 to 8.13.8 (go-gitea#18198) (go-gitea#18206)
@zeripath zeripath mentioned this pull request Jan 14, 2022
Merged
techknowlogick pushed a commit that referenced this pull request Jan 14, 2022
@zeripath @richmahn
Changelog for 1.15.10 (#18274) (#18276)
2b16ca7 
* Changelog for 1.15.10 (#18274)

[1.15.10](https://github.com/go-gitea/gitea/releases/tag/v1.15.10) - 2022-01-14

* BUGFIXES
  * Fix inconsistent PR comment counts (#18260) (#18261)
  * Fix release link broken (#18252) (#18253)
  * Fix update user from site administration page bug (#18250) (#18251)
  * Set HeadCommit when creating tags (#18116) (#18173)
  * Use correct translation key for error messages due to max repo limits (#18135 & #18153) (#18152)
  * Fix purple color in suggested label colors (#18241) (#18242)
* SECURITY
  * Bump mermaid from 8.10.1 to 8.13.8 (#18198) (#18206)

* update docs/config.yaml

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: Richard Mahn <richmahn@users.noreply.github.com>
@OCram85
Copy link
Contributor

OCram85 commented Jan 17, 2022

Just updated to gitea 1.15.10.
The link is fixed but the text seems to be broken. It often shows 0 commits but if you follow the link ist shows multiple commits on the diff page.

@zeripath
Copy link
Contributor

@OCram85 that's a different issue. This PR is simply fixing the link.

@zeripath
Copy link
Contributor

Please open a different issue for that probem.

Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@zeripath @richmahn
Changelog for 1.15.10 (go-gitea#18274) (go-gitea#18276)
2e1a71f 
* Changelog for 1.15.10 (go-gitea#18274)

[1.15.10](https://github.com/go-gitea/gitea/releases/tag/v1.15.10) - 2022-01-14

* BUGFIXES
  * Fix inconsistent PR comment counts (go-gitea#18260) (go-gitea#18261)
  * Fix release link broken (go-gitea#18252) (go-gitea#18253)
  * Fix update user from site administration page bug (go-gitea#18250) (go-gitea#18251)
  * Set HeadCommit when creating tags (go-gitea#18116) (go-gitea#18173)
  * Use correct translation key for error messages due to max repo limits (go-gitea#18135 & go-gitea#18153) (go-gitea#18152)
  * Fix purple color in suggested label colors (go-gitea#18241) (go-gitea#18242)
* SECURITY
  * Bump mermaid from 8.10.1 to 8.13.8 (go-gitea#18198) (go-gitea#18206)

* update docs/config.yaml

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: Richard Mahn <richmahn@users.noreply.github.com>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@zeripath zeripath zeripath left review comments

@KN4CK3R KN4CK3R KN4CK3R approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.15.10
Development

Successfully merging this pull request may close these issues.
7 participants
@lunny @OCram85 @zeripath @KN4CK3R @wxiaoguang @GiteaBot @6543