Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded debug messages to stdout. #18298

Merged
merged 3 commits into from
Jan 16, 2022
Merged

Remove unneeded debug messages to stdout. #18298

merged 3 commits into from
Jan 16, 2022

Conversation

odahoda
Copy link
Contributor

@odahoda odahoda commented Jan 16, 2022

Hi there,

I'm seeing messages like this in my syslog whenever someone (incl. bots) looks at some markdown file with a footnote:

Jan 15 15:29:07 *** gitea[2975]: GiteaFootnoteLink {
Jan 15 15:29:07 *** gitea[2975]:     Index: 1
Jan 15 15:29:07 *** gitea[2975]:     Name: [117 115 101 114 45 99 111 110 116 101 110 116 45 49]
Jan 15 15:29:07 *** gitea[2975]: }
Jan 15 15:29:07 *** gitea[2975]: source:
Jan 15 15:29:07 *** gitea[2975]: [...text of the footnote...]
Jan 15 15:29:07 *** gitea[2975]: source:

I'm assuming that this is just from some debug helpers left over from when the code was written and can be safely removed.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 16, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 16, 2022
@wxiaoguang wxiaoguang merged commit 2871e58 into go-gitea:main Jan 16, 2022
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jan 16, 2022
@wxiaoguang wxiaoguang added this to the 1.16.0 milestone Jan 16, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 17, 2022
@zjjhot
Merge branch 'main' of https://github.com/go-gitea/gitea
0fae813 
* 'main' of https://github.com/go-gitea/gitea:
  show pull link for agit pull request also (go-gitea#18235)
  [skip ci] Updated translations via Crowdin
  Add some .ignore entries (go-gitea#18296)
  Remove unneeded debug messages to stdout. (go-gitea#18298)
  Handle missing default branch better in owner/repo/branches page (go-gitea#18290)
  Revert "Prevent possible XSS when using jQuery (go-gitea#18289)" (go-gitea#18293)
  not show double error response in git hook (go-gitea#18292)
  Remove accidental debugging in blob_excerpt.tmpl (go-gitea#18287)
  Prevent possible XSS when using jQuery (go-gitea#18289)
  Return nicer error if trying to pull from non-existent user (go-gitea#18288)
  [skip ci] Updated translations via Crowdin
  docs: mention client_max_body_size affects LFS (go-gitea#18291)
  Add lockfile-check (go-gitea#18285)
  Webauthn nits (go-gitea#18284)
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@odahoda @wxiaoguang
Remove unneeded debug messages to stdout. (go-gitea#18298)
38e3c2f 
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@odahoda @wxiaoguang @delvh @GiteaBot