-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport: Upgrade EasyMDE 2.16.1 (package-lock.json) #18301
Backport: Upgrade EasyMDE 2.16.1 (package-lock.json) #18301
Conversation
Hmm ... why a new codemirror comes.
Let me see .... Gitea 1.15 uses Do maintainers have suggestions about how to deal with such dependency?
|
Yes do this after checking that the editor still works. AFAIU we're not really tightly depending on Codemirror - we're only using it as part of EasyMDE (and I think the githooks editor.) Even though we may import it directly it's only to ensure that we load syntax highlighting. I think therefore its version should be more tightly bound to EasyMDE than to any of our code. |
Yep, CodeMirror is only used by EasyMDE. I tested locally and EasyMDE works. PR is updated. |
Update CM as well. There is still a static version of CM in |
This PR follows #18279 to add forgotten package-lock.json
npm suggests:
So the
caniuse-lite
is also updated.