Left-Align text in Unicode warning boxes #18331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrapped text is more readable when left-aligned.
lafriks
added
the
skip-changelog
lafriks
approved these changes
Jan 19, 2022
GiteaBot
added
the
lgtm/need 1
|
Are you sure that it is more readable? |
|
It was initially raised in #17562 (comment). I guess two-line content is kind-of okay, but any more lines and it gets harder to read because lines start at different x-positions. |
|
Yup codeberg specifically asked for this. I put it in to the PR but it looks like it was removed or merged away. I think we have to do this. |
zeripath
approved these changes
Jan 19, 2022
GiteaBot
added
lgtm/done
|
I think codeberg wanted other messages to be left aligned too - I think originally my PR also covered those too. |
Gusted
approved these changes
Jan 19, 2022
zjjhot
pushed a commit
to zjjhot/gitea
that referenced
this pull request
Jan 20, 2022
* 'main' of https://github.com/go-gitea/gitea: Change initial TrustModel to committer (go-gitea#18335) refactor httplib (go-gitea#18338) Propagate context and ensure git commands run in request context (go-gitea#17868) Upgrade Alpine from 3.13 to 3.15 (go-gitea#18050) [skip ci] Updated translations via Crowdin Stop trimming preceding and suffixing spaces from editor filenames (go-gitea#18334) [skip ci] Updated translations via Crowdin Left-Align text in Unicode warning boxes (go-gitea#18331) Only warn on bidi but still escape non-bidi (go-gitea#18333) Fix incorrect OAuth message (go-gitea#18332) [skip ci] Updated translations via Crowdin Changelog for 1.16.0-rc1 (go-gitea#18309)
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
Wrapped text is more readable when left-aligned. Co-authored-by: Lauris BH <lauris@nix.lv> Co-authored-by: zeripath <art27@cantab.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrapped text is more readable when left-aligned.
Before:
After:
