Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to non-deprecation setting #18358

Merged
merged 7 commits into from
Jan 23, 2022
Merged

Switch to non-deprecation setting #18358

merged 7 commits into from
Jan 23, 2022

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Jan 22, 2022

  • Avoid by-default: "Deprecated fallback [server] LFS_CONTENT_PATH present. Use [lfs] PATH instead. This fallback will be removed in v1.18.0"

Switch to non-deprecation setting
3638d69 
- Avoid by-default: `Deprecated fallback `[server]` `LFS_CONTENT_PATH`
present. Use `[lfs]` `PATH` instead. This fallback will be removed in
v1.18.0`
@wxiaoguang
Copy link
Contributor

The app.example.ini should also be updated. I can not find lfs.PATH there.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 22, 2022
@zeripath
Copy link
Contributor

zeripath commented Jan 22, 2022 •
edited
Loading

Actually could we just migrate all of these LFS settings to [lfs]?

(LFS_JWT_SECRET - might need to stay where it is though - I think that needs to migrate to [secrets])

@Gusted
Copy link
Contributor Author

Gusted commented Jan 22, 2022

Actually could we just migrate all of these LFS settings to [lfs]?

(LFS_JWT_SECRET - might need to stay where it is though - I think that needs to migrate to [secrets])

Deprecate the current settings (like we do with LFS_CONTENT_PATH)?

@zeripath
Copy link
Contributor

I guess for the fallback deprecation probably needs to be for 1.19 removal.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 22, 2022
@Gusted
Copy link
Contributor Author

Gusted commented Jan 22, 2022

FYI: the Chinese config cheat sheet doesn't have a deprecation notice for the LFS_CONTENT_PATH key, the English one does.

@lunny lunny mentioned this pull request Jan 22, 2022
Merged
@lunny
Copy link
Member

lunny commented Jan 22, 2022

LFS_CONTENT_PATH

#18326

@lunny lunny reopened this Jan 23, 2022
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Jan 23, 2022 •
edited
Loading

Hmm ... GitHub auto closed this one ..... nvm

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 23, 2022
@zeripath zeripath added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jan 23, 2022
@zeripath zeripath added this to the 1.17.0 milestone Jan 23, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #18358 (8deb3fe) into main (e36f0b6) will increase coverage by 0.71%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18358      +/-   ##
==========================================
+ Coverage   45.34%   46.06%   +0.71%     
==========================================
  Files         841      840       -1     
  Lines       92860    92856       -4     
==========================================
+ Hits        42108    42770     +662     
+ Misses      44021    43301     -720     
- Partials     6731     6785      +54
Impacted Files Coverage Δ
routers/install/install.go 0.56% <0.00%> (ø)
modules/process/manager.go 81.39% <0.00%> (-1.56%) ⬇️
routers/api/v1/repo/pull.go 28.35% <0.00%> (-0.51%) ⬇️
services/pull/pull.go 42.39% <0.00%> (-0.41%) ⬇️
modules/migration/comment.go
modules/queue/queue_wrapped.go 5.26% <0.00%> (+3.94%) ⬆️
modules/charset/charset.go 75.75% <0.00%> (+4.04%) ⬆️
modules/queue/manager.go 43.84% <0.00%> (+24.13%) ⬆️
modules/queue/unique_queue_channel.go 41.12% <0.00%> (+39.51%) ⬆️
modules/queue/queue_bytefifo.go 53.18% <0.00%> (+53.18%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e36f0b6...8deb3fe. Read the comment docs.

@6543
Copy link
Member

6543 commented Jan 23, 2022

🚀

@6543 6543 merged commit 5e5740a into go-gitea:main Jan 23, 2022
@Gusted Gusted deleted the avoid-deprecation-notice branch January 23, 2022 19:10
zjjhot pushed a commit to zjjhot/gitea that referenced this pull request Jan 24, 2022
Merge branch 'main' of https://github.com/go-gitea/gitea
653a582 
* 'main' of https://github.com/go-gitea/gitea:
  [skip ci] Updated translations via Crowdin
  Fix partial cloning a repo (go-gitea#18373)
  Switch to non-deprecation setting (go-gitea#18358)
  Update the SSH passthrough documentation (go-gitea#18366)
  Don't underline commit status icon on hover (go-gitea#18372)
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
Switch to non-deprecation setting (go-gitea#18358)
743392f 
* Switch to non-deprecation setting
  (Avoid by-default: "Deprecated fallback `[server]` `LFS_CONTENT_PATH` present. Use `[lfs]` `PATH` instead. This fallback will be removed in v1.18.0")

* Update all references
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.
7 participants
@Gusted @wxiaoguang @zeripath @lunny @codecov-commenter @6543 @GiteaBot