-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always use git command but not os.Command #18363
Conversation
Codecov Report
@@ Coverage Diff @@
## main #18363 +/- ##
=======================================
Coverage ? 46.06%
=======================================
Files ? 838
Lines ? 92730
Branches ? 0
=======================================
Hits ? 42713
Misses ? 43233
Partials ? 6784
Continue to review full report at Codecov.
|
- Pass the Global command args into serviceRPC. - Fixes error with partial cloning.
* 'main' of https://github.com/go-gitea/gitea: Add packagist webhook (go-gitea#18224) Fix mime-type detection for HTTP server (go-gitea#18370) Always use git command but not os.Command (go-gitea#18363) Add deprecated for LFS_CONTENT_PATH on zh-cn docs (go-gitea#18362) [skip ci] Updated translations via Crowdin Make gitea, gitea-vet future-proof (go-gitea#18361) Pause queues (go-gitea#15928) Disable content sniffing on `PlainTextBytes` (go-gitea#18359) Update github.com/duo-labs/webauthn (go-gitea#18357)
return nil, fmt.Errorf("error creating StdoutPipe: %w", err) | ||
} | ||
go func(ctx context.Context, diffArgs []string, repoPath string, writer *io.PipeWriter) { | ||
cmd := git.NewCommandContextNoGlobals(ctx, diffArgs...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be NewCommandContext too. no it doesn't sorry Actually I'm really not sure about this.
I have a feeling that this should be NewCommandContext and we need to create our own lfs.filter.
No description provided.