Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ImagedProvider for gplus oauth2 provider #18504

Merged
merged 4 commits into from
Feb 1, 2022
Merged

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Jan 31, 2022

- Use `ImagedProvider` for gplus' oauthv2 provider, as the image isn't
"gplus.png" but "google.png".
- Resolves go-gitea#18494
@Gusted Gusted requested a review from zeripath January 31, 2022 20:47
@Gusted Gusted added backport/v1.16 issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change labels Jan 31, 2022
@Gusted Gusted added this to the 1.17.0 milestone Jan 31, 2022
Gusted pushed a commit to Gusted/gitea that referenced this pull request Jan 31, 2022
@Gusted Gusted added the backport/done All backports for this PR have been created label Jan 31, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 31, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 31, 2022
@codecov-commenter

This comment has been minimized.

@6543 6543 merged commit 22d2663 into go-gitea:main Feb 1, 2022
lunny pushed a commit that referenced this pull request Feb 1, 2022
- Bacport of #18504

Co-authored-by: 6543 <6543@obermui.de>
@Gusted Gusted deleted the fix-gplus-icon branch February 1, 2022 20:09
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 2, 2022
* giteaofficial/main: (37 commits)
  Collaborator trust model should trust collaborators (go-gitea#18539)
  Detect conflicts with 3way merge (go-gitea#18536)
  [skip ci] Updated translations via Crowdin
  Update 1.16.0 changelog to set go-gitea#17846 as breaking (go-gitea#18533)
  In docker rootless use $GITEA_APP_INI if provided (go-gitea#18524)
  revert to node14 for snapcraft
  Add `GetUserTeams` (go-gitea#18499)
  Fix review excerpt (go-gitea#18502)
  Update JS dependencies, fix lint (go-gitea#18389)
  add test coverage for original author conversion during migrations (go-gitea#18506)
  add gitea-fmt back (go-gitea#18526)
  Fix non-ASCII search on database  (go-gitea#18437)
  Use "read" value for General Access (go-gitea#18496)
  Fix for AvatarURL database type (go-gitea#18487)
  Remove go 1.15 support (go-gitea#18511)
  [skip ci] Updated translations via Crowdin
  Use `ImagedProvider` for gplus oauth2 provider (go-gitea#18504)
  build with node16 in snap (go-gitea#18508)
  point to s3 endpoint directly (go-gitea#18497)
  Fix OAuth Source Edit Page (go-gitea#18495)
  ...
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
Use `ImagedProvider` for gplus' oauthv2 provider, as the image isn't "gplus.png" but "google.png".

Resolves go-gitea#18494
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken icon image for Google OAuth2 provider
5 participants