-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate the details links of commit-statuses in headers #18661
Merged
wxiaoguang
merged 4 commits into
go-gitea:main
from
zeripath:fix-18498-part-2-separate-details-links
Feb 11, 2022
Merged
Separate the details links of commit-statuses in headers #18661
wxiaoguang
merged 4 commits into
go-gitea:main
from
zeripath:fix-18498-part-2-separate-details-links
Feb 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although go-gitea#18538 fixes the size of the header block the details links are still coalescing. Here we simply display: flex these instead of using .right Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added
type/bug
topic/ui
Change the appearance of the Gitea UI
backport/v1.16
labels
Feb 7, 2022
Codecov Report
@@ Coverage Diff @@
## main #18661 +/- ##
=======================================
Coverage ? 46.66%
=======================================
Files ? 846
Lines ? 121364
Branches ? 0
=======================================
Hits ? 56631
Misses ? 57853
Partials ? 6880 Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Feb 8, 2022
silverwind
approved these changes
Feb 11, 2022
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Feb 11, 2022
wxiaoguang
approved these changes
Feb 11, 2022
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Feb 11, 2022
wxiaoguang
approved these changes
Feb 11, 2022
wxiaoguang
added
the
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
label
Feb 11, 2022
We can have a backport now ~ |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Feb 11, 2022
wxiaoguang
pushed a commit
that referenced
this pull request
Feb 12, 2022
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 12, 2022
* giteaofficial/main: Send mail to issue/pr assignee/reviewer also when OnMention is set (go-gitea#18707) Reduce CI go module downloads, add make targets (go-gitea#18708) Add number in queue status to monitor page (go-gitea#18712) Fix source code line highlighting (go-gitea#18729) Fix forked repositories missed tags (go-gitea#18719) [skip ci] Updated translations via Crowdin Fix release typo (go-gitea#18728) Display template path of current page in dev mode (go-gitea#18717) Separate the details links of commit-statuses in headers (go-gitea#18661) Add LDAP group sync to Teams, fixes go-gitea#1395 (go-gitea#16299) Change git.cmd to RunWithContext (go-gitea#18693)
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport/done
All backports for this PR have been created
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
topic/ui
Change the appearance of the Gitea UI
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although #18538 fixes the size of the header block the details links are still
coalescing.
Here we simply display: flex these instead of using .right
Fix #18498
Signed-off-by: Andrew Thornton art27@cantab.net