-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always set PullRequestWorkInProgressPrefixes in PrepareViewPullInfo #18713
Merged
zeripath
merged 3 commits into
go-gitea:main
from
zeripath:fix-18706-prevent-NPE-in-pull-requests
Feb 11, 2022
Merged
Always set PullRequestWorkInProgressPrefixes in PrepareViewPullInfo #18713
zeripath
merged 3 commits into
go-gitea:main
from
zeripath:fix-18706-prevent-NPE-in-pull-requests
Feb 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move setting PullRequestWorkInProgressPrefixes to the start of PrepareViewPullInfo. Fix go-gitea#18706 Signed-off-by: Andrew Thornton <art27@cantab.net>
silverwind
approved these changes
Feb 11, 2022
GiteaBot
added
the
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
label
Feb 11, 2022
lunny
approved these changes
Feb 11, 2022
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Feb 11, 2022
Make lgtm work |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 11, 2022
* giteaofficial/main: Always set PullRequestWorkInProgressPrefixes in PrepareViewPullInfo (go-gitea#18713)
Please send backport |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Feb 12, 2022
…o-gitea#18713) Backport go-gitea#18713 Move setting PullRequestWorkInProgressPrefixes to the start of PrepareViewPullInfo. Fix go-gitea#18706 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added
backport/done
All backports for this PR have been created
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
labels
Feb 12, 2022
zeripath
added a commit
that referenced
this pull request
Feb 12, 2022
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
…o-gitea#18713) Move setting PullRequestWorkInProgressPrefixes to the start of PrepareViewPullInfo. Fix go-gitea#18706 Signed-off-by: Andrew Thornton <art27@cantab.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport/done
All backports for this PR have been created
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move setting PullRequestWorkInProgressPrefixes to the start of PrepareViewPullInfo.
Fix #18706
Signed-off-by: Andrew Thornton art27@cantab.net