-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename ctx.User
to ctx.Doer
#19161
Merged
Merged
Rename ctx.User
to ctx.Doer
#19161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KN4CK3R
added
the
type/refactoring
Existing code has been cleaned up. There should be no new functionality.
label
Mar 21, 2022
Merged
This comment was marked as outdated.
This comment was marked as outdated.
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Mar 21, 2022
lunny
approved these changes
Mar 22, 2022
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Mar 22, 2022
6543
approved these changes
Mar 22, 2022
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Mar 22, 2022
wxiaoguang
approved these changes
Mar 22, 2022
make L-G-T-M work |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 22, 2022
* giteaofficial/main: Fix the bug: deploy key with write access can not push (go-gitea#19010) Renamed ctx.User to ctx.Doer. (go-gitea#19161) [docs] Enhance container selection in docker dump (go-gitea#14292) Cleanup protected branches when deleting users & teams (go-gitea#19158) Reorder issue templates and automatically add labels (go-gitea#18875) Use IterateBufferSize whilst querying repositories during adoption check (go-gitea#19140)
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
type/refactoring
Existing code has been cleaned up. There should be no new functionality.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #18798 (comment)
I did not find a direct use of
User
in the templates. There is onlySignedUser
but that name may be ok.