SQLite has a query timeout. Hopefully fixes most 'database locked' errors #1961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkcsoft
force-pushed
the
bkcsoft-sqlite-timeout
branch
from
8526c10
to
1c78d80
Compare
|
Does this actually fix the problem? From what I can tell, this just means we'll get an error of the form "Busy timeout" instead of an error of the form "Table XYZ is locked" |
tboerger
added
the
lgtm/need 2
|
@ethantkoenig With this PR, SQLite should in theory wait for |
|
Oh I see, LGTM |
|
LGTM |
tboerger
added
lgtm/done
bkcsoft
changed the title
This was referenced Jun 15, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a wait timeout for when the database is locked. Hopefully this should fix the
database table is lockederrors.