-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace blue button and label classes with primary #19763
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
zeripath
reviewed
May 19, 2022
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
May 19, 2022
zeripath
approved these changes
May 19, 2022
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
May 19, 2022
wxiaoguang
reviewed
May 19, 2022
wxiaoguang
reviewed
May 19, 2022
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
wxiaoguang
approved these changes
May 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--color-blue-dark
is not what it means, otherwise LGTM.
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
May 19, 2022
Fixed in ca49f0d which adds all light color variants. For reference, it was produced on https://www.sassmeister.com/ using this source: :root {
--color-red-light: #{scale-color(#db2828, $lightness: +25%)};
--color-orange-light: #{scale-color(#f2711c, $lightness: +25%)};
--color-yellow-light: #{scale-color(#fbbd08, $lightness: +25%)};
--color-olive-light: #{scale-color(#b5cc18, $lightness: +25%)};
--color-green-light: #{scale-color(#21ba45, $lightness: +25%)};
--color-teal-light: #{scale-color(#00b5ad, $lightness: +25%)};
--color-blue-light: #{scale-color(#2185d0, $lightness: +25%)};
--color-violet-light: #{scale-color(#6435c9, $lightness: +25%)};
--color-purple-light: #{scale-color(#a333c8, $lightness: +25%)};
--color-pink-light: #{scale-color(#e03997, $lightness: +25%)};
--color-brown-light: #{scale-color(#a5673f, $lightness: +25%)};
--color-grey-light: #{scale-color(#888888, $lightness: +25%)};
--color-gold-light: #{scale-color(#a1882b, $lightness: +25%)};
} |
🚀 |
6543
approved these changes
May 19, 2022
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 20, 2022
* giteaofficial/main: Move org functions (go-gitea#19753) [doctor] pq: syntax error at or near "." quote user table name (go-gitea#19765) [doctor] update the help with fix capabilities (go-gitea#19762) Remove fomantic progress module (go-gitea#19760) Make Ctrl+Enter (quick submit) work for issue comment and wiki editor (go-gitea#19729) Enable packages by default again (as described by docs) (go-gitea#19746) Replace blue button and label classes with primary (go-gitea#19763) Fix org package owner permissions (go-gitea#19742)
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 24, 2022
* make blue really blue * replace blue button and label classes with primary * add --color-blue-dark * add light color variants, tweak a few colors * fix colors * add comment Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces and includes #19758.
Makes all buttons/labels use
primary
class instead ofblue
. There were a few cases wheresecondary
was more appropriate and I fixed the styling for it as well.