Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add silentcodeg to MAINTAINERS #19771

Merged
merged 4 commits into from
May 21, 2022
Merged

Add silentcodeg to MAINTAINERS #19771

merged 4 commits into from
May 21, 2022

Conversation

silentcodeg
Copy link
Contributor

@6543
Copy link
Member

6543 commented May 20, 2022

@silentcodeg are you on discord?

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 20, 2022
@silentcodeg
Copy link
Contributor Author

I am on matrix.

6543
6543 approved these changes May 20, 2022
View reviewed changes
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking forward to you contirbs

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 20, 2022
@6543 6543 added the type/docs This PR mainly updates/creates documentation label May 20, 2022
@6543
Copy link
Member

6543 commented May 20, 2022

I think you are already aware of https://matrix.to/#/#gitea-space:matrix.org

the maintainer chat is currently on discord only ... I might can create some bridging but expect it in the future

delvh
delvh approved these changes May 20, 2022
View reviewed changes
Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there a g missing?

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 20, 2022
6543
6543 reviewed May 21, 2022
View reviewed changes
MAINTAINERS Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@876cad0). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #19771   +/-   ##
=======================================
  Coverage        ?   47.31%           
=======================================
  Files           ?      957           
  Lines           ?   133298           
  Branches        ?        0           
=======================================
  Hits            ?    63066           
  Misses          ?    62575           
  Partials        ?     7657

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 876cad0...fa9c22f. Read the comment docs.

@lunny lunny merged commit f6c9929 into go-gitea:main May 21, 2022
@6543
Copy link
Member

6543 commented May 21, 2022

👋 @silentcodeg welcome in the team :) can you point me to your matrix id?

@silentcodeg
Copy link
Contributor Author

My matrix id is @silentcodeg thank you.

zjjhot added a commit to zjjhot/gitea that referenced this pull request May 21, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
788c3c5 
* giteaofficial/main:
  Prevent NPE when cache service is disabled (go-gitea#19703)
  Detect truncated utf-8 characters at the end of content as still representing utf-8 (go-gitea#19773)
  Add silentcodeg to MAINTAINERS (go-gitea#19771)
  Allows repo search to match against "owner/repo" pattern strings (go-gitea#19754)
  Update JS dependencies (go-gitea#19767)
  Nuke the incorrect permission report on /api/v1/notifications (go-gitea#19761)
@silentcodeg
Copy link
Contributor Author

Can you add me to the GitHub maintainers team?

@lunny
Copy link
Member

lunny commented May 22, 2022

@silentcodeg invited!!!

AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
@silentcodeg @lunny
@wxiaoguang @AbdulrhmnGhanem
Add silentcodeg to MAINTAINERS (go-gitea#19771)
74118dc 
* Add silentcodeg to MAINTAINERS

* add missing trailing g to chat nick

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@delvh delvh delvh approved these changes

@KN4CK3R KN4CK3R KN4CK3R approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@silentcodeg @6543 @codecov-commenter @lunny @silverwind @KN4CK3R @delvh @GiteaBot @wxiaoguang