Prevent loop if there is an error in GetNotificationCount #19799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the context is cancelled `.NotificationUnreadCount` in a template can cause an infinite loop with `ctx.ServerError()` being called, which creates a template that then calls `.NotificationUnreadCount` calling `GetNotificationCount()` with the cancelled context resulting in an error that calls `ctx.ServerError`... and so on... This PR simply stops calling `ctx.ServerError` in the error handler code for `.NotificationUnreadCount` as we have already started rendering and so it is too late to call `ctx.ServerError`. Additionally we skip logging the error if it's a context cancelled error. Fix go-gitea#19793 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added
type/bug
skip-changelog
silverwind
approved these changes
May 24, 2022
GiteaBot
added
the
lgtm/need 1
searching through the codebase for It genuinely looks like this is the only place - but obviously we need to be more careful in future. |
a1012112796
approved these changes
May 25, 2022
GiteaBot
added
lgtm/done
lunny
approved these changes
May 25, 2022
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 25, 2022
* giteaofficial/main: Prevent loop if there is an error in GetNotificationCount (go-gitea#19799) Add 'make tidy' (go-gitea#19800) Update document to use FHS `/usr/local/bin/gitea` instead of `/app/...` for Docker (go-gitea#19794)
zeripath
deleted the
fix-19793-prevent-loop-if-error-in-GetNotificationCount
branch
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 24, 2022
…9799) If the context is cancelled `.NotificationUnreadCount` in a template can cause an infinite loop with `ctx.ServerError()` being called, which creates a template that then calls `.NotificationUnreadCount` calling `GetNotificationCount()` with the cancelled context resulting in an error that calls `ctx.ServerError`... and so on... This PR simply stops calling `ctx.ServerError` in the error handler code for `.NotificationUnreadCount` as we have already started rendering and so it is too late to call `ctx.ServerError`. Additionally we skip logging the error if it's a context cancelled error. Fix go-gitea#19793 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the context is cancelled
.NotificationUnreadCountin a template cancause an infinite loop with
ctx.ServerError()being called, whichcreates a template that then calls
.NotificationUnreadCountcallingGetNotificationCount()with the cancelled context resulting in anerror that calls
ctx.ServerError... and so on...This PR simply stops calling
ctx.ServerErrorin the error handler codefor
.NotificationUnreadCountas we have already started rendering andso it is too late to call
ctx.ServerError. Additionally we skiplogging the error if it's a context cancelled error.
Fix #19793
Signed-off-by: Andrew Thornton art27@cantab.net