Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a "Builder" to Order SQL by X #19834

Closed
wants to merge 3 commits into from
Closed

Create a "Builder" to Order SQL by X #19834

wants to merge 3 commits into from

Conversation

6543
Copy link
Member

@6543 6543 commented May 29, 2022

as title

@6543 6543 added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label May 29, 2022
@6543 6543 added this to the 1.17.0 milestone May 29, 2022
delvh
delvh approved these changes May 29, 2022
View reviewed changes
Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from CI fail LGTM.

--- FAIL: TestSearchRepository (0.14s)

    --- FAIL: TestSearchRepository/OwnerSlashRepoSearch (0.00s)

        repo_list_test.go:281: 

            	Error Trace:	repo_list_test.go:281

            	Error:      	Received unexpected error:

            	            	Repo: near "ORDER": syntax error

            	Test:       	TestSearchRepository/OwnerSlashRepoSearch

models/repo_list.go
@@ -116,7 +117,7 @@ type SearchRepoOptions struct {
OwnerID int64
PriorityOwnerID int64
TeamID int64
OrderBy db.SearchOrderBy
OrderBy func(sess *xorm.Session) *xorm.Session
Private bool // Include private repositories in results
StarredByID int64
WatchedByID int64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I just noticed: Why do we have two times the same constants?
Once in db/search, and once here in L172+?

(The comment is here because GitHub doesn't let me comment down below)

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 29, 2022
@lunny
Copy link
Member

lunny commented May 30, 2022

I think we can wait https://gitea.com/xorm/xorm/pulls/2149

@lunny lunny mentioned this pull request Jun 3, 2022
Merged
zeripath added a commit that referenced this pull request Jun 4, 2022
@lunny @zeripath
Fix order by parameter (#19849)
12c742f 
Upgrade builder to v0.3.11
Upgrade xorm to v1.3.1 and fixed some hidden bugs.

Replace #19821
Replace #19834
Included #19850

Co-authored-by: zeripath <art27@cantab.net>
@lunny
Copy link
Member

lunny commented Jun 5, 2022

replaced by #19849

@lunny lunny closed this Jun 5, 2022
@lunny lunny removed this from the 1.17.0 milestone Jun 5, 2022
@6543 6543 deleted the use-more-builder branch June 9, 2022 09:30
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
@lunny @zeripath @AbdulrhmnGhanem
Fix order by parameter (go-gitea#19849)
3a8be9e 
Upgrade builder to v0.3.11
Upgrade xorm to v1.3.1 and fixed some hidden bugs.

Replace go-gitea#19821
Replace go-gitea#19834
Included go-gitea#19850

Co-authored-by: zeripath <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@6543 @lunny @delvh @GiteaBot