Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM Package Registry search API endpoint #20280

Merged
merged 10 commits into from
Sep 24, 2022

Conversation

jackv24
Copy link
Contributor

@jackv24 jackv24 commented Jul 7, 2022

WIP for #20098, implemented to match what's described here in the NPM registry API.

Currently have only implemented the bare minimum to work with the Unity Package Manager.

I've never written Go code before, and this is my first time contributing so please let me know if anything can be improved!

@jackv24 jackv24 marked this pull request as ready for review July 8, 2022 02:05
@jackv24
Copy link
Contributor Author

jackv24 commented Jul 8, 2022

There's a couple of things left that I'm not sure how to implement:

  • Verdaccio includes in the package section:
"time": {
    "modified": "2022-03-01T22:58:17.890Z"
},

This isn't included in the NPM specs that I linked, but Unity seems to read it to display publish time.


  • The name of the package in Unity appears as "com.test.packagename", but with Verdaccio it appeared as "Package Name". It looks like Verdaccio is returning the "displayName": field of the Unity-specific package.json. Would it be right to just add a DisplayName field to the package metadata structs, or should there be a more general way to show non-standard fields in package.json files?

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 8, 2022
@jackv24 jackv24 changed the title [WIP] NPM Package Registry search API endpoint NPM Package Registry search API endpoint Jul 12, 2022
@KN4CK3R
Copy link
Member

KN4CK3R commented Sep 16, 2022

Could you give me write access for your Gitea fork? I added some changes for this PR.

@jackv24
Copy link
Contributor Author

jackv24 commented Sep 16, 2022

Could you give me write access for your Gitea fork? I added some changes for this PR.

I do have Allow edits by maintainers checked, is there something else I need to do?

@KN4CK3R
Copy link
Member

KN4CK3R commented Sep 18, 2022

Could you please merge with the current main branch?

@KN4CK3R
Copy link
Member

KN4CK3R commented Sep 18, 2022

Thanks, added PR jackv24#1

@lunny lunny added this to the 1.18.0 milestone Sep 19, 2022
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 20, 2022
@wxiaoguang
Copy link
Contributor

@KN4CK3R , I think it looks good ~~

Copy link
Member

@KN4CK3R KN4CK3R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it's fine. I don't know if the registry should support these non-standard features for Unity. The search endpoint at it's own does work.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 24, 2022
@wxiaoguang wxiaoguang merged commit 83680c9 into go-gitea:main Sep 24, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 26, 2022
* upstream/main:
  [skip ci] Updated translations via Crowdin
  Typo in config-cheat-sheet (go-gitea#21261)
  Use native inputs in whitespace dropdown (go-gitea#20980)
  [skip ci] Updated licenses and gitignores
  Use en-US as fallback when using other default language (go-gitea#21200)
  Make NuGet service index publicly accessible (go-gitea#21242)
  Save files in local storage as umask (go-gitea#21198)
  NPM Package Registry search API endpoint (go-gitea#20280)
  [skip ci] Updated translations via Crowdin
  Added search input field to issue filter (go-gitea#20623)
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
@wxiaoguang
Copy link
Contributor

@jackv24 @KN4CK3R the code Registry: pd.FullWebLink() looks strange. Could you take a look at #29531 ?

Thank you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants