-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that drone tags 1.16.x and 1.16 on push to v1.16.x tag #20304
Conversation
We need pushes to v1.16.9 to create tags to 1.16.9 and 1.16 but not 1 or latest. We have previously adjusted the manifest to remove the latest tag, and have removed auto_tags so that 1 does not get tagged but in doing so we also stopped 1.16 being tagged. So here we just state the that we tag x.yy in addition to x.yyz*. Signed-off-by: Andrew Thornton <art27@cantab.net>
Does a release of the release/v1.17 branch make a |
What do you mean release of release/v1.17 branch? If you mean a tag from the v1.17 branch, yes it will. The .drone.yml file there has: Line 905 in 317c565
Which uses the drone-docker plugin to create the following tags: (see https://github.com/drone-plugins/drone-docker/blob/a842dfe5571a7f204e00d138458b67d6153de3b4/tags.go#L42-L72) return []string{
fmt.Sprintf("%0*d", len(dotParts[0]), version.Major),
fmt.Sprintf("%0*d.%0*d", len(dotParts[0]), version.Major, len(dotParts[1]), version.Minor),
fmt.Sprintf("%0*d.%0*d.%0*d", len(dotParts[0]), version.Major, len(dotParts[1]), version.Minor, len(dotParts[2]), version.Patch),
}, nil
This PR is only on the release/v1.16 branch. It makes no change to the v1.17 branch. Tags from the release/v1.16 will create tags on docker for 1.16 and 1.16.x and will not touch latest or 1 |
commit 713bc6c Author: 6543 <6543@obermui.de> Date: Tue Jul 12 20:26:27 2022 +0200 Changelog for 1.16.9 (update) (go-gitea#20341) * Changelog for 1.16.9 (update) * update security section commit 6b7e860 Author: Lunny Xiao <xiaolunwen@gmail.com> Date: Wed Jul 13 01:13:31 2022 +0800 Hide notify mail setting ui if not enabled (go-gitea#20138) (go-gitea#20337) Backport go-gitea#20138 commit 0f89417 Author: Gusted <williamzijl7@hotmail.com> Date: Tue Jul 12 12:52:20 2022 +0000 Add write check for creating Commit status (go-gitea#20332) (go-gitea#20334) - Backport go-gitea#20332 - Add write code checks for creating new commit status - Regression from go-gitea#5314 - Resolves go-gitea#20331 commit 7c80a0b Author: zeripath <art27@cantab.net> Date: Mon Jul 11 10:15:43 2022 +0100 Ensure that drone tags 1.16.x and 1.16 on push to v1.16.x tag (go-gitea#20304) We need pushes to v1.16.9 to create tags to 1.16.9 and 1.16 but not 1 or latest. We have previously adjusted the manifest to remove the latest tag, and have removed auto_tags so that 1 does not get tagged but in doing so we also stopped 1.16 being tagged. So here we just state the that we tag x.yy in addition to x.yyz*. Signed-off-by: Andrew Thornton <art27@cantab.net> commit b42df31 Author: zeripath <art27@cantab.net> Date: Wed Jul 6 02:47:16 2022 +0100 Only show Followers that current user can access (go-gitea#20220) (go-gitea#20253) Backport go-gitea#20220 Users who are following or being followed by a user should only be displayed if the viewing user can see them. Signed-off-by: Andrew Thornton <art27@cantab.net> commit 6162fb0 Author: Gusted <williamzijl7@hotmail.com> Date: Fri Jul 1 17:39:10 2022 +0200 Check for permission when fetching user controlled issues (go-gitea#20133) (go-gitea#20196) * Check if project has the same repository id with issue when assign project to issue * Check if issue's repository id match project's repository id * Add more permission checking * Remove invalid argument * Fix errors * Add generic check * Remove duplicated check * Return error + add check for new issues * Apply suggestions from code review Co-authored-by: Gusted <williamzijl7@hotmail.com> Co-authored-by: KN4CK3R <admin@oldschoolhack.me> Co-authored-by: 6543 <6543@obermui.de>
…ea#20304) We need pushes to v1.16.9 to create tags to 1.16.9 and 1.16 but not 1 or latest. We have previously adjusted the manifest to remove the latest tag, and have removed auto_tags so that 1 does not get tagged but in doing so we also stopped 1.16 being tagged. So here we just state the that we tag x.yy in addition to x.yyz*. Signed-off-by: Andrew Thornton <art27@cantab.net>
We need pushes to v1.16.9 to create tags to 1.16.9 and 1.16 but not 1 or latest.
We have previously adjusted the manifest to remove the latest tag, and have removed
auto_tags so that 1 does not get tagged but in doing so we also stopped 1.16 being
tagged. So here we just state the that we tag x.yy in addition to x.yyz*.
Signed-off-by: Andrew Thornton art27@cantab.net