refactor webhook *NewPost

[oliverpool]

Hi, this is a bit of yak-shaving: I wanted to add an Authorization Header to the webhooks. While working around the forms, I saw that the same code was repeated 11 times, I thought that it would be a good idea to refactor it before modifying it.

So here is a PR to refactor all *NewPost functions into a createWebhook function.

I did some minor modifications to Slack error handling, so that it doesn't need special code.

I am looking forward to your feedback!

[oliverpool]

The Slack error message looks like this with this PR:

[codecov-commenter]

Codecov Report

❗ No coverage uploaded for pull request base (main@fba2055). Click here to learn what that means.
The diff coverage is 0.00%.

❗ Current head fd06f07 differs from pull request most recent head 814a8b6. Consider uploading reports for the commit 814a8b6 to get more accurate results

@@           Coverage Diff           @@
##             main   #20729   +/-   ##
=======================================
  Coverage        ?   47.03%           
=======================================
  Files           ?      980           
  Lines           ?   136070           
  Branches        ?        0           
=======================================
  Hits            ?    64006           
  Misses          ?    64215           
  Partials        ?     7849           

Impacted Files	Coverage Δ
modules/web/middleware/binding.go	61.05% <0.00%> (ø)
routers/web/repo/webhook.go	1.33% <0.00%> (ø)
services/forms/repo_form.go	39.02% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[KN4CK3R]

I would remove the properties with default values but that's just my personal preference.

[oliverpool]

@KN4CK3R good point, done in 8eec61f

[wxiaoguang]

Wait , there seems to be 2 func isValidSlackChannel in code now. I will discard my early approval and wait until the PR becomes stable.

Wait for stable

[oliverpool]

@6543 since you advised removing, I actually removed utils.IsValidSlackChannel 😄

• its logic wasn't correct ( # was considered valid, since the strings.TrimSpace was not applied on if channelName[0] == '#'
• it makes the function much much shorter to let the caller take of strings.TrimSpace (which is needed anyway for saving in the database)

Since this is now a one-line function, I think copying is better than importing in this case:

func isValidSlackChannel(name string) bool {
	return name != "" && name != "#"
}

[oliverpool]

@wxiaoguang you are right. Let me move the IsValidSlackChannel function to slack.go, so that it is only in one place.

[silverwind]

Webhook Auth header is wip at #20267, by the way.

[6543]

.