make CheckPath logic clear #20823
Closed
make CheckPath logic clear #20823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
type/miscellaneous
backport/v1.17
skip-changelog
delvh
reviewed
Aug 18, 2022
|
|
||
| select { | ||
| case <-c.ctx.Done(): | ||
| return nil, c.ctx.Err() | ||
| return |
There was a problem hiding this comment.
Didn't we disable these kind of returns?
| @@ -55,7 +58,9 @@ func (repo *Repository) GetLanguageStats(commitID string) (map[string]int64, err | |||
|
|
|||
| if checker != nil { | |||
| attrs, err := checker.CheckPath(f.Name) | |||
| if err == nil { | |||
| if err != nil { | |||
| log.Error("CheckPath returns error: %v", err) | |||
There was a problem hiding this comment.
Why not
return errhere?
So either
Suggested change
| log.Error("CheckPath returns error: %v", err) | |
| log.Error("CheckPath returns error: %w", err) | |
| return err |
or
Suggested change
| log.Error("CheckPath returns error: %v", err) | |
| return err |
| if err == nil { | ||
| if err != nil { | ||
| log.Error("CheckPath returns error: %v", err) | ||
| } else { | ||
| if vendored, has := attrs["linguist-vendored"]; has { |
There was a problem hiding this comment.
Wait, we have the same code in two different files?
Should we perhaps extract the common things into one method?
GiteaBot
added
the
lgtm/need 2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #20709