Remove calls to load Mirrors in user.Dashboard #20855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whilst looking at go-gitea#20840 I noticed that the Mirrors data doesn't appear to be being used therefore we can remove this and in fact none of the related code is used elsewhere so it can also be removed. Related go-gitea#20840 Related go-gitea#20804 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added
the
type/refactoring
|
Can be backported as it is technically a bug to make these db requests unnecessarily - but should not hold up 1.17 |
GiteaBot
added
the
lgtm/need 2
silverwind
approved these changes
Aug 18, 2022
GiteaBot
added
lgtm/need 1
delvh
approved these changes
Aug 18, 2022
GiteaBot
added
lgtm/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Aug 19, 2022
* giteaofficial/main: Fix create repository page's help text (go-gitea#20810) In PushMirrorsIterate and MirrorsIterate if limit is negative do not set it (go-gitea#20837) Disable doctor logging on panic (go-gitea#20847) Remove calls to load Mirrors in user.Dashboard (go-gitea#20855) switch to node18 for snapcraft Prevent 500 is head repo does not have PullRequest unit in IsUserAllowedToUpdate (go-gitea#20839) Fix owners cannot create organization repos bug (go-gitea#20841)
|
Please send backport to 1.17 |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Aug 21, 2022
Backport go-gitea#20855 Whilst looking at go-gitea#20840 I noticed that the Mirrors data doesn't appear to be being used therefore we can remove this and in fact none of the related code is used elsewhere so it can also be removed. Related go-gitea#20840 Related go-gitea#20804 Signed-off-by: Andrew Thornton <art27@cantab.net> Signed-off-by: Andrew Thornton <art27@cantab.net>
lunny
added a commit
that referenced
this pull request
Aug 22, 2022
Backport #20855 Whilst looking at #20840 I noticed that the Mirrors data doesn't appear to be being used therefore we can remove this and in fact none of the related code is used elsewhere so it can also be removed. Related #20840 Related #20804 Signed-off-by: Andrew Thornton <art27@cantab.net> Signed-off-by: Andrew Thornton <art27@cantab.net> Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
vsysoev
pushed a commit
to IntegraSDL/gitea
that referenced
this pull request
Aug 28, 2022
Whilst looking at go-gitea#20840 I noticed that the Mirrors data doesn't appear to be being used therefore we can remove this and in fact none of the related code is used elsewhere so it can also be removed. Related go-gitea#20840 Related go-gitea#20804 Signed-off-by: Andrew Thornton <art27@cantab.net> Signed-off-by: Andrew Thornton <art27@cantab.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst looking at #20840 I noticed that the Mirrors data doesn't appear
to be being used therefore we can remove this and in fact none of the
related code is used elsewhere so it can also be removed.
Related #20840
Related #20804
Signed-off-by: Andrew Thornton art27@cantab.net