Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the document about how to collect logs for systemd and docker #21101

Merged
merged 2 commits into from
Sep 7, 2022

Conversation

wxiaoguang
Copy link
Contributor

Many users (#21099) do not know how to collect logs if they are using systemd. This PR makes the document more clear.

@wxiaoguang wxiaoguang added the type/docs This PR mainly updates/creates documentation label Sep 7, 2022
@wxiaoguang wxiaoguang added this to the 1.18.0 milestone Sep 7, 2022
@@ -120,10 +120,6 @@ In Gitea, an "active" user refers to a user that has activated their account via

A "login prohibited" user is a user that is not allowed to log in to Gitea anymore

## Setting up logging
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need to link to this

Copy link
Contributor Author

@wxiaoguang wxiaoguang Sep 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted

I removed it before because there is already a clear "Logging configuration" in the left menu, so IMO it's not necessary to put a single link in FAQ again. Keeping it is also fine.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 7, 2022
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 7, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 7, 2022
@lunny
Copy link
Member

lunny commented Sep 7, 2022

make L-G-T-M work.

@lunny lunny merged commit aa5de4d into go-gitea:main Sep 7, 2022
@wxiaoguang wxiaoguang deleted the doc-log-help branch September 8, 2022 03:26
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 9, 2022
* upstream/main:
  Make the vscode clone link respect transport protocol (go-gitea#20557)
  Fix typo of issue template name (go-gitea#21117)
  [skip ci] Updated translations via Crowdin
  Fix pagination limit parameter problem (go-gitea#21109)
  Rewrite go license generator in go (go-gitea#21078)
  Allow uppercase ASCII alphabet in PyPI package names (go-gitea#21095)
  Fix various typos (go-gitea#21103)
  Update docs issue-pull-request-templates.zh-cn.md (go-gitea#21030)
  Upgrade the document about how to collect logs for systemd and docker (go-gitea#21101)
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants