Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show label description in comments section #21156

Merged
merged 4 commits into from
Sep 16, 2022
Merged

Show label description in comments section #21156

merged 4 commits into from
Sep 16, 2022

Conversation

JakobDev
Copy link
Contributor

Not much to say here. The labels in the comment section are currently missing the description that all other labels have.

delvh
delvh approved these changes Sep 13, 2022
View reviewed changes
Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me.
I suspect that someone would prefer the JS-based alternative…
Let's see if they find this PR.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 13, 2022
@JakobDev
Copy link
Contributor Author

I suspect that someone would prefer the JS-based alternative…

The title attribute is used for all other label positions, so this shoud be OK.

@delvh
Copy link
Member

delvh commented Sep 13, 2022

As I said: I'm not the one complaining.

delvh
delvh requested changes Sep 14, 2022
View reviewed changes
Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wxiaoguang is absolutely right, I missed that.

@silverwind
Copy link
Member

Fine for me. I suspect that someone would prefer the JS-based alternative… Let's see if they find this PR.

I guess not everything has to be a JS-based tooltip. Can't really say whether I prefer title here without testing.

wxiaoguang
wxiaoguang approved these changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the title attribute (the light tip) could be fine for this case.
It's also easy to be switched to use tippy popup, either is good to me since there is no guideline yet about whether the title attribute should be avoided.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 15, 2022
@wxiaoguang
Copy link
Contributor

ps: GitHub uses customized popup tooltip for labels, maybe it's time to have a guideline.

@silverwind
Copy link
Member

silverwind commented Sep 15, 2022 •
edited
Loading

I think the title attribute (the light tip) could be fine for this case. It's also easy to be switched to use tippy popup, either is good to me since there is no guideline yet about whether the title attribute should be avoided.

There is other labels that already uses title like in the issue list, so it's certainly consistent.

@wxiaoguang wxiaoguang merged commit 548387b into go-gitea:main Sep 16, 2022
@JakobDev JakobDev deleted the labeldesc branch September 16, 2022 14:22
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 19, 2022
@zjjhot
Merge remote-tracking branch 'upstream/main'
15d11c1 
* upstream/main:
  Fix typo (go-gitea#21201)
  Remove unnecessary length check for repo's Description & Website (go-gitea#21194)
  Treat git object mode 40755 as directory (go-gitea#21195)
  Fix reaction of issues (go-gitea#21185)
  Fix CSV diff for added/deleted files (go-gitea#21189)
  Show label description in comments section (go-gitea#21156)
  Limit length of repo description and repo url input fields (go-gitea#21119)
@wxiaoguang wxiaoguang added this to the 1.18.0 milestone Oct 7, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh requested changes

@silverwind silverwind silverwind left review comments

@noerw noerw noerw approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.
Projects
None yet
Milestone
1.18.0
Development

Successfully merging this pull request may close these issues.
6 participants
@JakobDev @delvh @silverwind @wxiaoguang @noerw @GiteaBot