Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop logging CheckPath returns error: context canceled (#21064) #21405

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

zeripath
Copy link
Contributor

Backport #21064

We should only log CheckPath errors if they are not simply due to context cancellation - and we should add a little more context to the error message.

Fix #20709

Signed-off-by: Andrew Thornton art27@cantab.net

Backport go-gitea#21064

We should only log CheckPath errors if they are not simply due to
context cancellation - and we should add a little more context to the
error message.

Fix go-gitea#20709

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added this to the 1.17.3 milestone Oct 10, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 10, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 11, 2022
@lunny lunny merged commit 1f804d3 into go-gitea:release/v1.17 Oct 11, 2022
tyroneyeh pushed a commit to tyroneyeh/gitea that referenced this pull request Oct 24, 2022
… (go-gitea#21405)

Backport go-gitea#21064

We should only log CheckPath errors if they are not simply due to
context cancellation - and we should add a little more context to the
error message.

Fix go-gitea#20709

Signed-off-by: Andrew Thornton <art27@cantab.net>

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath deleted the backport-21064-v1.17 branch December 29, 2022 19:19
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants