Check if email is used when updating user (#21289) #21750
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfogre
approved these changes
Nov 10, 2022
GiteaBot
added
the
lgtm/need 1
lunny
approved these changes
Nov 10, 2022
GiteaBot
added
lgtm/done
|
CI failure is related. |
6543
approved these changes
Nov 12, 2022
lafriks
requested changes
Nov 19, 2022
models/user/user.go
Outdated
| IsPrimary: false, | ||
| }); err != nil { | ||
| return err | ||
| if has && emailAddress.UID != u.ID { |
There was a problem hiding this comment.
What if email exists and is not active? This way I could add to my account let's say others person's email address and block him from adding his other email
There was a problem hiding this comment.
Agreed, but that brings another change with it:
We need to throw out unactivated emails then when someone else changes his email and verifies it.
There was a problem hiding this comment.
It's a backport, should I modify this patch?
There was a problem hiding this comment.
Yes, I think this should be fixed
added 3 commits
November 25, 2022 21:22
Signed-off-by: Xinyu Zhou <i@sourcehut.net>
wow, just noticed. |
|
Going to close this as we've moved on from |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #21289
Fix #21075
When updating user data should check if email is used by other users