Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update message of reach_limit_of_creation #21757

Merged
merged 6 commits into from
Nov 11, 2022
Merged

Update message of reach_limit_of_creation #21757

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4051080
chore: update reach_limit_of_creation
wolfogre Nov 10, 2022
52bccb1
chore: fix word
wolfogre Nov 10, 2022
3ef3e1c
Merge branch 'main' into bugfix/fix_reach_limit_of_creation
wolfogre Nov 10, 2022
12cd476
Merge branch 'main' into bugfix/fix_reach_limit_of_creation
lafriks Nov 10, 2022
85bacc2
Merge branch 'main' into bugfix/fix_reach_limit_of_creation
techknowlogick Nov 10, 2022
6d09495
Merge branch 'main' into bugfix/fix_reach_limit_of_creation
wolfogre Nov 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions options/locale/locale_en-US.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -944,8 +944,8 @@ archive.title = This repo is archived. You can view files and clone it, but cann
archive.issue.nocomment = This repo is archived. You cannot comment on issues.
archive.pull.nocomment = This repo is archived. You cannot comment on pull requests.

form.reach_limit_of_creation_1 = You have already reached your limit of %d repository.
form.reach_limit_of_creation_n = You have already reached your limit of %d repositories.
form.reach_limit_of_creation_1 = The owner has already reached the limit of %d repository.
form.reach_limit_of_creation_n = The owner has already reached the limit of %d repositories.
Comment on lines +947 to +948
Copy link
Member

@delvh delvh Nov 10, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But is that the typical situation for this error message?
I think this change will confuse users that actually reached the limit themselves:

Why is the message suddenly talking about some mysterious unknown owner and not me?
Is that message even directed at me?

The best compromise I can come up with is the following:

Suggested change
form.reach_limit_of_creation_1 = The owner has already reached the limit of %d repository.
form.reach_limit_of_creation_n = The owner has already reached the limit of %d repositories.
form.reach_limit_of_creation_1 = You or the selected owner has already reached the limit of %d repository.
form.reach_limit_of_creation_n = You or the selected owner has already reached the limit of %d repositories.

Any better ideas?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the owner not you. When you create a repo under your username, the limitation depends on you. When you create a repo under an org, the limitation depends on the org's limitation. When you create a repo under other user(you are an admin?), the limitation depends on that user.

Copy link
Member Author

@wolfogre wolfogre Nov 11, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"You or the selected owner" is a little ambiguous, it sounds like you can't create a repo if either you or the owner has reached the limit.

I think the "owner" word may cause a little confusion, but the form is self explanatory, there's still a "owner" selector when the user is creating a repo for himself.

image

form.name_reserved = The repository name '%s' is reserved.
form.name_pattern_not_allowed = The pattern '%s' is not allowed in a repository name.

Expand Down