Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compiling without sqlite and gcc #2177

Merged
merged 1 commit into from
Jul 26, 2017
Merged

Fix compiling without sqlite and gcc #2177

merged 1 commit into from
Jul 26, 2017

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Jul 17, 2017

Fixes #2172

@lafriks lafriks added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Jul 17, 2017
@lunny lunny added this to the 1.2.0 milestone Jul 18, 2017
@lunny lunny added the type/bug label Jul 18, 2017
@lunny
Copy link
Member

lunny commented Jul 18, 2017

No. the build tag is not in the correct place

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 18, 2017
@lafriks
Copy link
Member Author

lafriks commented Jul 18, 2017

@lunny sorry that build tag was leftover from first try to fix compilation with no gcc, it was not needed, fixed

@lunny
Copy link
Member

lunny commented Jul 19, 2017

maybe rename models/unit_tests.go to models/unit_test.go is better?

@ethantkoenig
Copy link
Member

@lunny No, it is important that models/unit_tests.go is not treated as a test file; otherwise the integration tests will not be able to import it.

@ethantkoenig
Copy link
Member

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 19, 2017
@Bwko
Copy link
Member

Bwko commented Jul 22, 2017 •
edited
Loading

LGTM

@lafriks lafriks added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 24, 2017
@lunny
Copy link
Member

lunny commented Jul 26, 2017

make CI work

@lunny lunny merged commit 1d032f5 into go-gitea:master Jul 26, 2017
@cez81 cez81 mentioned this pull request Dec 9, 2017
Closed
7 tasks
@lafriks lafriks deleted the fix/build_without_sqlite branch December 10, 2017 10:08
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile type/bug
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

Building Gitea will build go-sqlite3 with or without the sqlite build tag
5 participants
@lafriks @lunny @ethantkoenig @Bwko @tboerger