Fix cocurrent upload package #21836
Fix cocurrent upload package #21836
Conversation
| has, err := e.Exist(key) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| if has { | ||
| return key, ErrDuplicatePackage | ||
| } | ||
| return nil, err |
There was a problem hiding this comment.
That's wrong. You might get has=false, err=nil then return nil, nil
GiteaBot
added
the
lgtm/need 2
| @@ -128,14 +128,21 @@ func TryInsertPackage(ctx context.Context, p *Package) (*Package, error) { | |||
| LowerName: p.LowerName, | |||
| } | |||
|
|
|||
| has, err := e.Get(key) | |||
| has, err := e.Exist(key) | |||
There was a problem hiding this comment.
I think this is wrong because Exist does not populate the object with the content from the database.
|
And this doesn't fix the current problem because the error does not occur in these methods but when the transaction is committed. |
Although I haven't looked into the problem, I think using transaction correctly will resolve the concurrency problem. Database transactions will acquire |
When inserting failed, then check if the record does exist, if yes, then just return the record duplicated.