-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement FSFE REUSE for golang files #21840
Conversation
I only changed comments, can someone help explain why CI is failing? |
The errors in the CI should point them out, but for example https://github.com/go-gitea/gitea/pull/21840/files#diff-52617ef219e61332d7bc880cd52ab7f34e21fb813040907db1c210837ccc3e95 It looks like whatever you used to mass-replace also broke some of the package statements. |
Thank you @jolheiser. My find replace was on an exact string, but there were some lines that had extra text it was not commented any longer. |
This reverts commit 7043561.
@jolheiser I have fixed the tests so they now pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess if this is the way that the OSS ecosystem is going then we should do this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I'm terribly sorry, GitHub, for DDOsing you with JS requests only to notice afterward that there were much easier options available…)
Were you benefited from SPDX? Or just help it become a widely accepted standard. I'm not against this PR. |
make lgtm work |
OK this is going to take some work to ensure that we remain compliant as we go forward. This means that we should probably add a REUSE compliance check to make check |
Was just about to post we should add this to our vet check |
* giteaofficial/main: Use random bytes to generate access token (go-gitea#21959) Replace fmt.Sprintf with hex.EncodeToString (go-gitea#21960) Implement FSFE REUSE for golang files (go-gitea#21840) Correct the fallbacks for mailer configuration (go-gitea#21945) [skip ci] Updated licenses and gitignores Fix typos (go-gitea#21947) Fix markdown anchor re-clicking (go-gitea#21931) Prevent NPE if trying to restore an already restored deleted branch (go-gitea#21940) add rel="me" to org.website link (go-gitea#21941)
I think this may help: https://gitea.com/gitea/gitea-vet/pulls/21 I'll update the check of Gitea when the PR above has been merged. |
Related to: - #21840 - https://gitea.com/gitea/gitea-vet/pulls/21 What it looks like when it's working: https://drone.gitea.io/go-gitea/gitea/64040/1/5 All available SPDX license identifiers: [SPDX License List](https://spdx.org/licenses/). Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
fixes #16132