Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix markdown anchor re-clicking #21931

Merged
merged 9 commits into from
Nov 26, 2022
Merged

Fix markdown anchor re-clicking #21931

Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e6d2846
Fix markdown anchor re-clicking
silverwind Nov 24, 2022
7609431
Merge branch 'main' into hashclick
lunny Nov 25, 2022
ba54e4e
Merge branch 'main' into hashclick
lunny Nov 25, 2022
cfaddde
Merge branch 'main' into hashclick
lunny Nov 25, 2022
df6c8aa
add initial condition
silverwind Nov 25, 2022
5746f9d
reword comment
silverwind Nov 25, 2022
91a34cc
avoid implicit false
silverwind Nov 25, 2022
cbed4f9
Merge branch 'main' into hashclick
lunny Nov 25, 2022
0ef0235
Merge branch 'main' into hashclick
zeripath Nov 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions web_src/js/markup/anchors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,11 @@ import {svg} from '../svg.js';

const headingSelector = '.markup h1, .markup h2, .markup h3, .markup h4, .markup h5, .markup h6';

function scrollToAnchor() {
if (document.querySelector(':target')) return;
if (!window.location.hash || window.location.hash.length <= 1) return;
const id = decodeURIComponent(window.location.hash.substring(1));
function scrollToAnchor(hash, initial) {
// abort if the browser has already scrolled to another anchor during page load
if (initial && document.querySelector(':target')) return;
if (hash?.length <= 1) return;
const id = decodeURIComponent(hash.substring(1));
const el = document.getElementById(`user-content-${id}`);
if (el) {
el.scrollIntoView();
Expand All @@ -24,9 +25,11 @@ export function initMarkupAnchors() {
a.classList.add('anchor');
a.setAttribute('href', `#${encodeURIComponent(originalId)}`);
a.innerHTML = svg('octicon-link');
a.addEventListener('click', (e) => {
scrollToAnchor(e.currentTarget.getAttribute('href'), false);
});
heading.prepend(a);
}

scrollToAnchor();
window.addEventListener('hashchange', scrollToAnchor);
scrollToAnchor(window.location.hash, true);
}