Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go get github.com/wadey/gocovmerge when needed #2235

Merged
merged 1 commit into from
Jul 31, 2017
Merged

go get github.com/wadey/gocovmerge when needed #2235

merged 1 commit into from
Jul 31, 2017

Conversation

sapk
Copy link
Member

@sapk sapk commented Jul 30, 2017

During #2198 I have found that gocovmerge is not automatically get when needed.

@lafriks
Copy link
Member

lafriks commented Jul 30, 2017

LGTM

@bkcsoft bkcsoft added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 30, 2017
@lunny lunny added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Jul 31, 2017
@lunny lunny added this to the 1.2.0 milestone Jul 31, 2017
@lunny
Copy link
Member

lunny commented Jul 31, 2017

LGTM

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 31, 2017
@lunny lunny merged commit a804f0e into go-gitea:master Jul 31, 2017
@sapk sapk deleted the go-get-gocovmerge branch July 31, 2017 09:48
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@sapk @lafriks @lunny @bkcsoft