Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CLI option tenant ID for oauth2 source #22769

Merged
merged 2 commits into from
Feb 6, 2023
Merged

Add CLI option tenant ID for oauth2 source #22769

merged 2 commits into from
Feb 6, 2023

Conversation

Adito5393
Copy link
Contributor

Fixes #22713

@techknowlogick techknowlogick added the type/enhancement An improvement of existing functionality label Feb 5, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 5, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 5, 2023
@lunny lunny added this to the 1.19.0 milestone Feb 5, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 5, 2023
@jolheiser
Copy link
Member

🎺 🤖

@jolheiser jolheiser merged commit c13eb8e into go-gitea:main Feb 6, 2023
@jolheiser jolheiser removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 6, 2023
@Adito5393 Adito5393 mentioned this pull request Feb 6, 2023
Closed
@Adito5393 Adito5393 deleted the add-cmd-cli-tenant-oauth2 branch February 6, 2023 10:16
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 7, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
dee12a7 
* upstream/main:
  Fix restore repo bug, clarify the problem of ForeignIndex (go-gitea#22776)
  Grammar fix (go-gitea#22790)
  Use link in UI which returned a relative url but not html_url which contains an absolute url (go-gitea#21986)
  Add repo adoption to FAQ (go-gitea#22778)
  Use import of OCI structs (go-gitea#22765)
  Update gogs upgrade information (go-gitea#22777)
  Add CLI option tenant ID for oauth2 source (go-gitea#22769)
  Refactor legacy strange git operations (go-gitea#22756)
  Add Chef package registry (go-gitea#22554)
  use drone secrets for s3 config (go-gitea#22770)
  remove update language in ProfilePost (go-gitea#22748)
  Set PR for issue when load attributes for PRs (go-gitea#22766)
  Fix time to NotifyPullRequestSynchronized (go-gitea#22650)
@Adito5393
Copy link
Contributor Author

Hey @jolheiser I've just checked the 1.18.5 release & this PR is not part of it.
What does it need to make it into the next (patch/minor/major) release?

@yardenshoham
Copy link
Member

Hey jolheiser I've just checked the 1.18.5 release & this PR is not part of it. What does it need to make it into the next (patch/minor/major) release?

You could send a backport to the v1.18 branch

@Adito5393 Adito5393 restored the add-cmd-cli-tenant-oauth2 branch March 3, 2023 09:13
Adito5393 added a commit to Adito5393/gitea that referenced this pull request Mar 3, 2023
@Adito5393
Add CLI option tenant ID for oauth2 source (go-gitea#22769)
695d553 
Backport go-gitea#22769

Fixes go-gitea#22713
@Adito5393 Adito5393 mentioned this pull request Mar 3, 2023
Merged
@Adito5393 Adito5393 deleted the add-cmd-cli-tenant-oauth2 branch March 3, 2023 09:49
@yardenshoham
Copy link
Member

If there are no objections from the maintainers, we can backport it

@yardenshoham yardenshoham added outdated/backport/v1.18 This PR should be backported to Gitea 1.18 backport/done All backports for this PR have been created labels Mar 5, 2023
@jolheiser
Copy link
Member

If there are no objections from the maintainers, we can backport it

Sounds good to me! @Adito5393 sorry I missed your question in my emails! 😅

lunny added a commit that referenced this pull request Mar 6, 2023
@Adito5393 @lunny
Add CLI option tenant ID for oauth2 source (#22769) (#23263)
805c592 
Backport #22769

Fixes #22713

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. outdated/backport/v1.18 This PR should be backported to Gitea 1.18 type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.19.0
Development

Successfully merging this pull request may close these issues.

CLI misses the Tenant flag for the authentication source Azure AD v2 (OAuth2)
6 participants
@Adito5393 @jolheiser @yardenshoham @lunny @techknowlogick @GiteaBot