-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use GitHub Actions compatible globbing for branches
, tag
, path
filter
#22804
Conversation
c075ec2
to
b25bae0
Compare
Could you resolve the conflicts? |
Looks like nektos/act#1618 merged, we can just use those functions with no duplicated copy. |
branches
, tag
, path
filter
Do you mean instead of converting to regex or instead of a custom globbing implementation based on GitHub Actions docs?
Not merged in gitea/act, so I'm still waiting for the replicated changes. This was the initial reason to first include it in the act fork and delay gitea's integrations. |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #22804 +/- ##
==========================================
- Coverage 47.14% 47.14% -0.01%
==========================================
Files 1149 1156 +7
Lines 151446 152399 +953
==========================================
+ Hits 71397 71843 +446
- Misses 71611 72077 +466
- Partials 8438 8479 +41
... and 14 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Since #23512 merged, now can reduce the duplicated code. |
…filter (go-gitea#22804) Replaces the current globbing library with a https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet compatible one. This adds support for - `paths-ignore`, `tags-ignore` and `branches-ignore` filters. - negative patterns in `paths`, `tags` and `branches` filters - using both `tags` and `paths` filter on the push event Original PR https://gitea.com/gitea/act/pulls/13. nektos/act PR nektos/act#1618 for the workflowpattern package (It can take some months for it to appear in https://gitea.com/gitea/act) Related to go-gitea#13539
…filter (#22804) (#23740) Backport #22804 by @ChristopherHX Replaces the current globbing library with a https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet compatible one. This adds support for - `paths-ignore`, `tags-ignore` and `branches-ignore` filters. - negative patterns in `paths`, `tags` and `branches` filters - using both `tags` and `paths` filter on the push event Original PR https://gitea.com/gitea/act/pulls/13. nektos/act PR nektos/act#1618 for the workflowpattern package (It can take some months for it to appear in https://gitea.com/gitea/act) Related to #13539 Co-authored-by: ChristopherHX <christopher.homberger@web.de>
* upstream/main: Fix issue due date edit toggle bug (go-gitea#23723) Fix profile page email display, respect settings (go-gitea#23747) Update Gitea version in docs (go-gitea#23755) Fix SVG close tag, improve commit graph page UI alignment (go-gitea#23751) Remove incorrect HTML self close tag (go-gitea#23748) Refactor repo commit list (go-gitea#23690) Fix tags view (go-gitea#23243) Add commit info in action page (go-gitea#23210) Use GitHub Actions compatible globbing for `branches`, `tag`, `path` filter (go-gitea#22804)
Replaces the current globbing library with a https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet compatible one.
This adds support for
paths-ignore
,tags-ignore
andbranches-ignore
filters.paths
,tags
andbranches
filterstags
andpaths
filter on the push eventOriginal PR https://gitea.com/gitea/act/pulls/13.
nektos/act PR nektos/act#1618 for the workflowpattern package (It can take some months for it to appear in https://gitea.com/gitea/act)
Related to #13539